Closed
Bug 1298937
Opened 7 years ago
Closed 7 years ago
about:newtab settings icon overlaps with search bar when the viewport is 600 pixels
Categories
(Firefox :: New Tab Page, defect)
Tracking
()
VERIFIED
FIXED
Firefox 55
People
(Reporter: alex_mayorga, Assigned: adi.srivastava)
Details
Attachments
(4 files)
17.85 KB,
image/png
|
Details | |
705 bytes,
patch
|
adw
:
review+
|
Details | Diff | Splinter Review |
243.79 KB,
image/png
|
shorlander
:
ui-review+
|
Details |
41.20 KB,
image/png
|
Details |
Steps: - Resize a Firefox window to 600 pixels horizontal. - Load about:newtab Result: about:newtab settings icon overlaps with search bar Result: about:newtab settings icon doesn't overlap with search bar
Assignee | ||
Comment 1•7 years ago
|
||
I've reproduced this issue on Ubuntu and lubuntu too; should I create a new issue for those? I would like to work on this bug, and would greatly appreciate someone walking me through how to go about it.
Comment 2•7 years ago
|
||
(In reply to Aditya Srivastava from comment #1) > I've reproduced this issue on Ubuntu and lubuntu too; should I create a new > issue for those? I see this on Mac as well, so we can say all platforms. > I would like to work on this bug, and would greatly appreciate someone > walking me through how to go about it. The source code for the newtab page lives here: https://dxr.mozilla.org/mozilla-central/source/browser/base/content/newtab You should be able to inspect the page by opening up a new tab, then going to Tools -> Web Developer -> Inspector. From there you can look at the css and experiment with different options. I believe Dão has also been doing most work in this area recently, so he may be able to help as well.
OS: Windows 7 → All
Hardware: x86_64 → All
Updated•7 years ago
|
Assignee: nobody → adi.srivastava
Assignee | ||
Comment 3•7 years ago
|
||
I was able to fix the overlap by moving the search bar 15px down. I've worked with git but never with Mercurial so I'm not sure if what I did is right, but I committed my changes and then exported them out to a file which I'm attaching here.
Flags: needinfo?(standard8)
Assignee | ||
Comment 4•7 years ago
|
||
The button for the dropdown menu no longer overlaps with the search bar even when active.
Comment 5•7 years ago
|
||
Hi Aditya, attaching a patch is fine. Using mozreview is something to consider for later, but starting with attaching is OK! We'll need UX review on this, so I'll request it in a moment.
Flags: needinfo?(standard8)
Comment 6•7 years ago
|
||
Comment on attachment 8820377 [details]
Screenshot showing the modified and rebuilt newtab page
Stephen, could you take a look at the changes here please? The patch is moving the search bar 15px further down.
Attachment #8820377 -
Flags: ui-review?(shorlander)
Comment 7•7 years ago
|
||
Comment on attachment 8820377 [details]
Screenshot showing the modified and rebuilt newtab page
Looks good to me.
Attachment #8820377 -
Flags: ui-review?(shorlander) → ui-review+
Comment 8•7 years ago
|
||
Comment on attachment 8820374 [details] [diff] [review] Exported diff of the changes made. Hi Aditya, I'm sorry, I only just noticed this got ui+. Lets get it reviewed and hopefully landed.
Attachment #8820374 -
Flags: review?(adw)
Comment 9•7 years ago
|
||
Comment on attachment 8820374 [details] [diff] [review] Exported diff of the changes made. Review of attachment 8820374 [details] [diff] [review]: ----------------------------------------------------------------- Thanks Mark.
Attachment #8820374 -
Flags: review?(adw) → review+
Comment 10•7 years ago
|
||
Simple css change, try push shouldn't be necessary.
Keywords: checkin-needed
Comment 11•7 years ago
|
||
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/637d897a3364 Fix overlap by changing search bar's margin-top attribute. r=adw
Keywords: checkin-needed
Comment 12•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/637d897a3364
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Comment 13•7 years ago
|
||
[bugday-20170419] BROWSER:Firefox Nightly 55.0a1 OS: Windows 10.0 The bug is no longer reproducible, hence verified.
Updated•7 years ago
|
Comment 14•7 years ago
|
||
[bugday-20170426] Os:Windows 7 (32 bit) Browser : Firefox Nightly 55.oa1 Result : Fixed and Verified I can able to reproduce the bug and the about : :newtab settings icon are appears normally
Comment 15•7 years ago
|
||
Operating system : Windows 7 (32 bit) firefox Browser version::Firefox 54.0a2 This occurs when i reproduce the bug it Result into about:newtab settings icon doesn't overlap with search bar.It just positioned in correct place. BUGID::[1298937]
Reporter | ||
Comment 16•7 years ago
|
||
¡Hola Fahima, Balaji and Sreerag! Thanks for veryfying this. ¡Gracias! Alex
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•