Initialize AsyncPanZoomController global state in GPU process

RESOLVED FIXED in Firefox 51

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: rhunt, Assigned: rhunt)

Tracking

unspecified
mozilla51
Points:
---

Firefox Tracking Flags

(firefox51 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Assignee

Description

3 years ago
In the GPU process we should call AsyncPanZoomController::InitializeGlobalState ahead of the lazy initialization in APZCTreeManager. This will let us make sure it's on the main thread.
Assignee

Comment 1

3 years ago
Posted patch apz-global-state.patch (obsolete) — Splinter Review
Attachment #8786132 - Flags: review?(bugmail)
Comment on attachment 8786132 [details] [diff] [review]
apz-global-state.patch

Review of attachment 8786132 [details] [diff] [review]:
-----------------------------------------------------------------

Can we instead move the first two lines in the APZCTreeManager constructor (the assert and the call to AsyncPanZoomController) into a new static APZCTreeManager::InitializeGlobalState function and call that from GPUParent? Then we don't have to expose all those internal apz headers because GPUParent will not need to include AsyncPanZoomController.h.
Attachment #8786132 - Flags: review?(bugmail) → review-
Assignee

Comment 3

3 years ago
Posted patch init-apz-global.patch (obsolete) — Splinter Review
Attachment #8786132 - Attachment is obsolete: true
Attachment #8786985 - Flags: review?(bugmail)
Assignee

Comment 4

3 years ago
Forgot an assert.
Attachment #8786985 - Attachment is obsolete: true
Attachment #8786985 - Flags: review?(bugmail)
Attachment #8786987 - Flags: review?(bugmail)
Comment on attachment 8786987 [details] [diff] [review]
init-apz-global.patch

Review of attachment 8786987 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!
Attachment #8786987 - Flags: review?(bugmail) → review+
Assignee

Updated

3 years ago
Keywords: checkin-needed

Comment 6

3 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/246d2a65316a
Initialize AsyncPanZoomController global state in GPU Process. r=kats
Keywords: checkin-needed

Comment 7

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/246d2a65316a
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.