1298980 - Initialize AsyncPanZoomController global state in GPU process

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Ryan Hunt [:rhunt]]

In the GPU process we should call AsyncPanZoomController::InitializeGlobalState ahead of the lazy initialization in APZCTreeManager. This will let us make sure it's on the main thread.

Comment 1

[Ryan Hunt [:rhunt]]

Attachment: apz-global-state.patch

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8786132 [details] [diff] [review]
apz-global-state.patch

Review of attachment 8786132 [details] [diff] [review]:
-----------------------------------------------------------------

Can we instead move the first two lines in the APZCTreeManager constructor (the assert and the call to AsyncPanZoomController) into a new static APZCTreeManager::InitializeGlobalState function and call that from GPUParent? Then we don't have to expose all those internal apz headers because GPUParent will not need to include AsyncPanZoomController.h.

Comment 3

[Ryan Hunt [:rhunt]]

Attachment: init-apz-global.patch

Comment 4

[Ryan Hunt [:rhunt]]

Attachment: init-apz-global.patch

Forgot an assert.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8786987 [details] [diff] [review]
init-apz-global.patch

Review of attachment 8786987 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/246d2a65316a
Initialize AsyncPanZoomController global state in GPU Process. r=kats

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/246d2a65316a