1299018 - Report late frames as dropped instead of presented

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P1)

Description

[JW Wang [:jwwang] [:jw_wang]]

Per bug 1258870 comment 20, I will work on a safe patch which doesn't change the playback behaviour to uplift to beta (49).

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1299018 - Report late frames as dropped instead of presented.

Review commit: https://reviewboard.mozilla.org/r/75166/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/75166/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Quotes from Chris about uplifting bug 1258870 to beta:

"We can however uplift a fix to beta that will report the late frames as being being dropped instead of actually dropping them. So you'll still get bad A/V sync, but your adaption code will be able to detect that the decode can't keep up and be able to drop back to a lower bitrate, which the user's machine should be able to handle decoding in real time."

So we have this bug for a safe approach.

Comment 3

[Kilik Kuo [:kikuo] (inactive)]

Comment on attachment 8786196 [details]
Bug 1299018 - Report late frames as dropped instead of presented.

https://reviewboard.mozilla.org/r/75166/#review73430

Looks fine to me.

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8786196 [details]
Bug 1299018 - Report late frames as dropped instead of presented.

Approval Request Comment
[Feature/regressing bug #]:A safer alternative for bug 1258870 which is not uplifted for being considered medium risk.
[User impact if declined]: Late frames are incorrectly reported as presented instead of dropped which prevents the player from detecting dropped frames and switching to a lower resolution for smoother playback.
[Describe test coverage new/current, TreeHerder]: TreeHerder
[Risks and why]: Low. The change is simple.
[String/UUID change made/needed]: None.

Comment 6

[Blake Wu [:bwu][:blakewu]]

We need this patch to mitigate a partner issue.

Comment 7

[Gerry Chang [:gchang]]

Comment on attachment 8786196 [details]
Bug 1299018 - Report late frames as dropped instead of presented.

This patch fixes a A/V sync issue. Take it in 49 beta. Should be in 49 beta 9.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d66985bce16c