Remove unnecessary calls to ScheduleStateMachine() following SetState(DECODER_STATE_DECODING)

RESOLVED FIXED in Firefox 51

Status

()

P3
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jwwang, Assigned: jwwang)

Tracking

unspecified
mozilla51
Points:
---

Firefox Tracking Flags

(firefox51 fixed)

Details

Attachments

(3 attachments)

(Assignee)

Description

2 years ago
The entry action of DECODER_STATE_DECODING calls ScheduleStateMachine(). We can remove the calls following |SetState(DECODER_STATE_DECODING)|.
(Assignee)

Updated

2 years ago
Assignee: nobody → jwwang
Blocks: 1295892
Priority: -- → P3
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

2 years ago
Attachment #8786610 - Flags: review?(kaku)
Attachment #8786611 - Flags: review?(kaku)
Attachment #8786612 - Flags: review?(kaku)

Comment 4

2 years ago
mozreview-review
Comment on attachment 8786610 [details]
Bug 1299064. Part 1 - move |SetState(nextState)| and ScheduleStateMachine() to the bottom of SeekCompleted().

https://reviewboard.mozilla.org/r/75534/#review73510
Attachment #8786610 - Flags: review?(kaku) → review+

Comment 5

2 years ago
mozreview-review
Comment on attachment 8786611 [details]
Bug 1299064. Part 2 - remove the if/else statement at the end of SeekCompleted().

https://reviewboard.mozilla.org/r/75536/#review73512
Attachment #8786611 - Flags: review?(kaku) → review+

Comment 6

2 years ago
mozreview-review
Comment on attachment 8786612 [details]
Bug 1299064. Part 3 - remove the calls to ScheduleStateMachine() following |SetState(DECODER_STATE_DECODING)|.

https://reviewboard.mozilla.org/r/75538/#review73514
Attachment #8786612 - Flags: review?(kaku) → review+
(Assignee)

Comment 7

2 years ago
Thanks for the review!

Comment 8

2 years ago
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c9f208e04b62
Part 1 - move |SetState(nextState)| and ScheduleStateMachine() to the bottom of SeekCompleted(). r=kaku
https://hg.mozilla.org/integration/autoland/rev/437650642dd8
Part 2 - remove the if/else statement at the end of SeekCompleted(). r=kaku
https://hg.mozilla.org/integration/autoland/rev/0e3958b3ee0f
Part 3 - remove the calls to ScheduleStateMachine() following |SetState(DECODER_STATE_DECODING)|. r=kaku

Comment 9

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c9f208e04b62
https://hg.mozilla.org/mozilla-central/rev/437650642dd8
https://hg.mozilla.org/mozilla-central/rev/0e3958b3ee0f
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.