Closed Bug 1299064 Opened 5 years ago Closed 5 years ago

Remove unnecessary calls to ScheduleStateMachine() following SetState(DECODER_STATE_DECODING)

Categories

(Core :: Audio/Video: Playback, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: jwwang, Assigned: jwwang)

References

Details

Attachments

(3 files)

The entry action of DECODER_STATE_DECODING calls ScheduleStateMachine(). We can remove the calls following |SetState(DECODER_STATE_DECODING)|.
Assignee: nobody → jwwang
Blocks: 1295892
Priority: -- → P3
Attachment #8786610 - Flags: review?(kaku)
Attachment #8786611 - Flags: review?(kaku)
Attachment #8786612 - Flags: review?(kaku)
Comment on attachment 8786610 [details]
Bug 1299064. Part 1 - move |SetState(nextState)| and ScheduleStateMachine() to the bottom of SeekCompleted().

https://reviewboard.mozilla.org/r/75534/#review73510
Attachment #8786610 - Flags: review?(kaku) → review+
Comment on attachment 8786611 [details]
Bug 1299064. Part 2 - remove the if/else statement at the end of SeekCompleted().

https://reviewboard.mozilla.org/r/75536/#review73512
Attachment #8786611 - Flags: review?(kaku) → review+
Comment on attachment 8786612 [details]
Bug 1299064. Part 3 - remove the calls to ScheduleStateMachine() following |SetState(DECODER_STATE_DECODING)|.

https://reviewboard.mozilla.org/r/75538/#review73514
Attachment #8786612 - Flags: review?(kaku) → review+
Thanks for the review!
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c9f208e04b62
Part 1 - move |SetState(nextState)| and ScheduleStateMachine() to the bottom of SeekCompleted(). r=kaku
https://hg.mozilla.org/integration/autoland/rev/437650642dd8
Part 2 - remove the if/else statement at the end of SeekCompleted(). r=kaku
https://hg.mozilla.org/integration/autoland/rev/0e3958b3ee0f
Part 3 - remove the calls to ScheduleStateMachine() following |SetState(DECODER_STATE_DECODING)|. r=kaku
You need to log in before you can comment on or make changes to this bug.