Set cookies and allow for session labels display in two lines in Polish nightly

NEW
Unassigned

Status

()

Firefox
Site Identity and Permission Panels
P5
normal
a year ago
11 months ago

People

(Reporter: stef, Unassigned)

Tracking

({regression})

Trunk
regression
Points:
---

Firefox Tracking Flags

(firefox48 unaffected, firefox49 unaffected, firefox50 unaffected, firefox51 wontfix, firefox52 fix-optional, firefox53 fix-optional)

Details

(Whiteboard: [fxprivacy] )

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

a year ago
Created attachment 8786294 [details]
Set cookies allow for session permission screenshot

In latest Polish nightly (probably after bug 1290174), "Set cookies" permission label and "Allow for session" setting are displayed in two lines (this in not the case in 49).
(Reporter)

Comment 1

a year ago
Created attachment 8786297 [details]
Set cookies allow for session permission screenshot
Attachment #8786294 - Attachment is obsolete: true
I'd say this is just an unfortunate edge case of a formatting that usually works well. I'd call it wontfix, but I'll mark it for triage so that we can discuss it.
Component: General → Site Identity and Permission Panels
Whiteboard: [fxprivacy] [triage]
(Reporter)

Comment 3

a year ago
If UI benefits somehow from such change then maybe but I don't really see anything like that or a reason to not display this in one line.
We increased the font size. If it were possible to get it on one line, the layout would do that automatically.
(Reporter)

Comment 5

a year ago
If bug 1290174 comment 0 is indeed the reason then please update the dialog size to also match the mockup.
What's wrong with breaking the text? How many other Polish permission list items are breaking?
(Reporter)

Comment 7

a year ago
Nothing wrong or broken but permissions/settings in one line look way better, more readable and closer to the mockup.
AFAIK set coockies is the only permission in two lines.
Is there any chance to make the width of this dialog customizable per locale? I know cases where that's technically not possible (e.g. hamburger button), not sure if this is the same.
Priority: -- → P5
Whiteboard: [fxprivacy] [triage] → [fxprivacy]

Comment 9

a year ago
(In reply to Francesco Lodolo [:flod] from comment #8)
> Is there any chance to make the width of this dialog customizable per
> locale? I know cases where that's technically not possible (e.g. hamburger
> button), not sure if this is the same.

We talked about this at today's team planning meeting. For the Control Center we can likely use a localizable width, like we do with the Downloads Panel. However, it's a low priority for us to implement this system if the issue only occurs for the cookies permission, which doesn't appear at all for most users during normal usage.

If we hear more reports for more common permission then we could revisit this, and we can probably use localization screenshots for various locales to see if this problem occurs elsewhere.
Note that bug 1290174 comment 1 was spot-on in that we were just using the default system text size there, so the concern that this might be illegible for some people was basically misguided and we could revert that change.
Keywords: regression
status-firefox48: --- → unaffected
status-firefox49: --- → unaffected
status-firefox50: --- → unaffected
status-firefox51: --- → fix-optional
status-firefox51: fix-optional → wontfix
status-firefox52: --- → fix-optional
status-firefox53: --- → fix-optional
Version: unspecified → Trunk
Whiteboard: [fxprivacy] → [fxprivacy] [triage]

Updated

11 months ago
Whiteboard: [fxprivacy] [triage] → [fxprivacy]
(In reply to Dão Gottwald [:dao] from comment #10)
> Note that bug 1290174 comment 1 was spot-on in that we were just using the
> default system text size there, so the concern that this might be illegible
> for some people was basically misguided and we could revert that change.

Philipp, we need some UX guidance here.

Updated

11 months ago
Flags: needinfo?(philipp)
With regards to the smaller text size: I think both sizes work in terms of aesthetics and legibility. However, it is not clear to me as that this would entirely avoid the text breaking issue. Do we know that we don't have breaking languages (Russian, for example, gets notoriously long) with the smaller text size?
Flags: needinfo?(philipp)
You need to log in before you can comment on or make changes to this bug.