1299126 - [linux] location bar (awesomebar) results popup is transparent on some gtk themes, making results impossible to read

Status: RESOLVED DUPLICATE of bug 1328352

(Firefox :: Theme, defect, P2)

Description

[Daniel Convissor]

Attachment: screen shot of awesome bar transparent background

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:48.0) Gecko/20100101 Firefox/48.0
Build ID: 20160728204513

Steps to reproduce:

0) (created new profile to ensure not a problem with my settings)
1) Put cursor in location bar
2) Type "we"


Actual results:

Background of awesome bar results is transparent. So the result text is not guaranteed to contrast with the background color of the current web page.  Result is frequent inability to see the results.

This started happening upon upgrading to Firefox 48.


Expected results:

Text should be visible regardless of the colors of the web page being viewed.

Comment 1

[Tooru Fujisawa [:arai]]

Are you using distro package of firefox?
If so, can you check with mozilla's build?

Also, are you using some there to change the UI color?
If so, can you provide the detail?

Comment 2

[Daniel Convissor]

Using Ubuntu firefox_48.0+build2-0ubuntu0.14.04.1_amd64.deb.

Will look into testing a Mozilla build.

While my usual profile tweaks colors, before reporting I tested and produced screen shot from a brand new profile where no settings were changed.

Comment 3

[Drew Willcoxon :adw]

Possibly related to bug 1275700?

Comment 4

[Marco Bonardo [:mak]]

This should have been fixed in the meanwhile?

Comment 5

[Marco Bonardo [:mak]]

Likely WFM now, no answer.

Comment 6

[Daniel Convissor]

Sorry for dropping the ball. Changed from Ubuntu to Debian (8/jessie).  Debian had a 45 based Firefox.

I upgraded Firefox today and it's now at 52.2.0esr-1~deb8u1.  And the bug is back (for me).

As mentioned earlier, I had set up a new Firefox profile for testing and the problem appeared there.

As another test, just now, I used FF in another user account on this machine and the rendering problem does NOT show up there.  So perhaps it's some interaction with my Gnome theme that makes it show up.  My Gnome theme is High Contrast Inverse.

Of course, FF should have a defined background color to ensure it works regardless of the user's theme.

Thanks.

Comment 7

[Daniel Convissor]

Attachment: Gnome High Contrast Inverse theme

This is my Gnome theme.

Comment 8

[Daniel Convissor]

Unzip it in /usr/share, then use gnome-tweak-tool to enable it.

Comment 9

[Daniel Convissor]

Did some further testing.  Used Gnome tweak tool to change my Gnome color schemes to Adwaita and to High Contrast.  Both rendered the awesome bar autocomplete results fine.

Comment 10

[Daniel Convissor]

The main source of the regression is setting the dropdown background to transparent, which happened via Bug 1285642 commit
https://hg.mozilla.org/releases/mozilla-beta/rev/f8606cd63ad2

 .addengine-item {
-  background-color: Menu;
-  color: MenuText;
+  background-color: transparent;
+  color: inherit;

Then another, Bug 1275700, compounded the problem by making the typeahead results'
URL text gray in commit
https://hg.mozilla.org/releases/mozilla-beta/rev/2605c36cc363

 #urlbar-search-settings {
-  color: inherit;
+  color: GrayText;

I will attach a screen shot of the problem with this gray text in a moment.

Comment 11

[Daniel Convissor]

Attachment: Gray typeahead URL text may not contrast with background

Comment 12

[Ben Kelly [:bkelly, not reviewing]]

Dao, any thoughts on this?  Is the blocking bug the correct source of this problem?

Comment 13

[Dão Gottwald [:dao]]

(In reply to Ben Kelly [:bkelly] from comment #12)
> Dao, any thoughts on this?  Is the blocking bug the correct source of this
> problem?

No, bug 1285642 only made .addengine-item's background transparent. That's an element within the search bar's popup. It's not even present in the location bar's popup.

Comment 14

[Dão Gottwald [:dao]]

This is more likely a regression from bug 1275700. That set -moz-appearance: none; on the popup so background-color: -moz-Field; should be used now. There was a bug causing -moz-Field to be transparent, supposedly fixed in bug 1328352. I'll mark this a duplicate. Please reopen if you can still reproduce this in Firefox 53 or later.