Add Accel+shift+z for redo on all platforms

VERIFIED FIXED in mozilla1.0

Status

()

Core
Keyboard: Navigation
P1
normal
VERIFIED FIXED
17 years ago
16 years ago

People

(Reporter: Aaron Leventhal, Assigned: Aaron Leventhal)

Tracking

Trunk
mozilla1.0
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

17 years ago
Netscape is adding this keybinding because of a confidential customer
requirement; if Mozilla would like to be compatible, here's the change,
otherwise we'll have to take it in our tree only.

Our normal binding for redo, Accel+Y will remain for now.

Accel+shift+Z is actually used for redo in a variety of Windows programs,
including notepad, Visual Studio, and ordinary text fields. There is no clear
standard for redo, except that it can be Accel+Y or Accel+shift+Z.
(Assignee)

Updated

17 years ago
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → mozilla1.0
(Assignee)

Comment 1

17 years ago
Created attachment 73433 [details] [diff] [review]
Adds accel+shift+z binding for redo on Win/Linux. Same patch that had r=jgaunt, sr=sfraser in bugscape 12250
OS: Windows 2000 → All
Hardware: PC → All

Comment 2

17 years ago
Why doesn't this patch just remove it from the Mac file and put it in the
cross-platform file?
(Assignee)

Comment 3

17 years ago
You're right, it should be in all of them. Call me crazy, I don't remember what
my original reason was.
(Assignee)

Comment 4

17 years ago
Created attachment 73580 [details] [diff] [review]
Puts everything in htmlBindings.xml instead of platform specific files
Attachment #73433 - Attachment is obsolete: true

Comment 5

17 years ago
Comment on attachment 73580 [details] [diff] [review]
Puts everything in htmlBindings.xml instead of platform specific files

r=jgaunt
Attachment #73580 - Flags: review+

Comment 6

17 years ago
in the Mac-specific file, you added some spaces (tabs?) after <handlers> please
remove those so diff wouldn't show that you touched that line.
(Assignee)

Comment 7

17 years ago
Created attachment 73583 [details] [diff] [review]
Whitespace to brade's specification

Comment 8

17 years ago
Comment on attachment 73583 [details] [diff] [review]
Whitespace to brade's specification

r=brade (although you *can* remove the blank line if you want)
Attachment #73583 - Flags: review+

Updated

17 years ago
Attachment #73583 - Flags: superreview+

Comment 9

17 years ago
Comment on attachment 73583 [details] [diff] [review]
Whitespace to brade's specification

sr=alecf

Comment 10

17 years ago
Comment on attachment 73583 [details] [diff] [review]
Whitespace to brade's specification

a=asa (on behalf of drivers) for checkin to the 1.0 trunk
Attachment #73583 - Flags: approval+
(Assignee)

Comment 11

17 years ago
checked in
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
vrfy'd fixed with 2002.07.23-1.0 comm branch bits.

linux rh7.2, win2k: both shift+ctrl+Z and ctrl+Y behave as redo.
mac os x 10.1.5: only shift+cmd+Z behaves as redo. (if this isn't expected, feel
free to reopen.)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.