129916 - Add Accel+shift+z for redo on all platforms

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P1)

Description

[Aaron Leventhal]

Netscape is adding this keybinding because of a confidential customer
requirement; if Mozilla would like to be compatible, here's the change,
otherwise we'll have to take it in our tree only.

Our normal binding for redo, Accel+Y will remain for now.

Accel+shift+Z is actually used for redo in a variety of Windows programs,
including notepad, Visual Studio, and ordinary text fields. There is no clear
standard for redo, except that it can be Accel+Y or Accel+shift+Z.

Comment 1

[Aaron Leventhal]

Attachment: Adds accel+shift+z binding for redo on Win/Linux. Same patch that had r=jgaunt, sr=sfraser in bugscape 12250

Comment 2

[Kathleen :Brade]

Why doesn't this patch just remove it from the Mac file and put it in the
cross-platform file?

Comment 3

[Aaron Leventhal]

You're right, it should be in all of them. Call me crazy, I don't remember what
my original reason was.

Comment 4

[Aaron Leventhal]

Attachment: Puts everything in htmlBindings.xml instead of platform specific files

Comment 5

[John Gaunt (redfive)]

Comment on attachment 73580 [details] [diff] [review]
Puts everything in htmlBindings.xml instead of platform specific files

r=jgaunt

Comment 6

[Kathleen :Brade]

in the Mac-specific file, you added some spaces (tabs?) after <handlers> please
remove those so diff wouldn't show that you touched that line.

Comment 7

[Aaron Leventhal]

Attachment: Whitespace to brade's specification

Comment 8

[Kathleen :Brade]

Comment on attachment 73583 [details] [diff] [review]
Whitespace to brade's specification

r=brade (although you *can* remove the blank line if you want)

Comment 9

[Alec Flett]

Comment on attachment 73583 [details] [diff] [review]
Whitespace to brade's specification

sr=alecf

Comment 10

[Asa Dotzler [:asa]]

Comment on attachment 73583 [details] [diff] [review]
Whitespace to brade's specification

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 11

[Aaron Leventhal]

checked in

Comment 12

[sairuh (rarely reading bugmail)]

vrfy'd fixed with 2002.07.23-1.0 comm branch bits.

linux rh7.2, win2k: both shift+ctrl+Z and ctrl+Y behave as redo.
mac os x 10.1.5: only shift+cmd+Z behaves as redo. (if this isn't expected, feel
free to reopen.)