Closed Bug 1299197 Opened 3 years ago Closed 3 years ago

[Pointer Events] Should also serialize tiltX and tiltY when serializing WidgetMouseEvents

Categories

(Core :: DOM: Events, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: bhsu, Assigned: stone)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 2 obsolete files)

Though it's pretty weird to serial tiltX and tiltY for mouse input, we have to do this, since Windows send mouse platform messages for pen inputs and touch, which are latter wrapped into WidgetMouseEvent by Gecko. Thus, WidgetMouseEvent doesn't only represent mouse input but also pen and touch.

Besides, it would be nice to match the hierarchies of both Widget****Event and their corresponding serializers.
Component: Event Handling → DOM: Events
Summary: [Pointer Events] Should also serialize tiltX and tiltY when serializing WidgetMouseEvent → [Pointer Events] Should also serialize tiltX and tiltY when serializing WidgetMouseEvents
Is this something we want to have in the next release/months, i.e. P2? Or is it closer to a nice-to-have (P3) speaking from now?
Blocks: pointerevent
Flags: needinfo?(sshih)
Flags: needinfo?(bhsu)
IMHO, if we are going to launch Pointer Events in any form (i.e., pre-release), then it's P3 (nice-to-have); However, if we're not launching Pointer Events, then this issue has nothing to do with the very next release ;P
Flags: needinfo?(bhsu)
In this stage, I think we can set this bug as nice-to-have
Flags: needinfo?(sshih)
Thanks!
Priority: -- → P3
Blocks: 1293129
Assignee: nobody → sshih
Blocks: 1315676
Attachment #8814781 - Flags: review?(bugs)
Attachment #8814782 - Flags: review?(bugs)
Attachment #8814781 - Flags: review?(bugs) → review+
Comment on attachment 8814782 [details] [diff] [review]
Part2: Serialize WidgetPointerHelper in IPC message

> template<>
>+struct ParamTraits<mozilla::WidgetPointerHelper>
>+{
>+  typedef mozilla::WidgetPointerHelper paramType;
>+
>+  static void Write(Message* aMsg, const paramType& aParam)
>+  {
>+    WriteParam(aMsg, aParam.pointerId);
>+    WriteParam(aMsg, aParam.tiltX);
>+    WriteParam(aMsg, aParam.tiltY);
>+    // We don't serialize convertToPointer and retargetedByPointerCapture since
>+    // they are temporarily variable and sould be reset to default.
s/sould/should/
Attachment #8814782 - Flags: review?(bugs) → review+
Updated the patch summary.
Attachment #8814781 - Attachment is obsolete: true
Attachment #8815541 - Flags: review+
Updated the patch summary and comments.
Attachment #8814782 - Attachment is obsolete: true
Attachment #8815542 - Flags: review+
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fd2c8004db8a
Part1: Refine WidgetPointerHelper. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/eece9df96e36
Part2: Serialize WidgetPointerHelper in IPC messag. r=smaug
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/fd2c8004db8a
https://hg.mozilla.org/mozilla-central/rev/eece9df96e36
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.