1299197 - [Pointer Events] Should also serialize tiltX and tiltY when serializing WidgetMouseEvents

Status: RESOLVED FIXED

(Core :: DOM: Events, defect, P3)

Description

[Ben Hsu [:HoPang]]

Though it's pretty weird to serial tiltX and tiltY for mouse input, we have to do this, since Windows send mouse platform messages for pen inputs and touch, which are latter wrapped into WidgetMouseEvent by Gecko. Thus, WidgetMouseEvent doesn't only represent mouse input but also pen and touch.

Besides, it would be nice to match the hierarchies of both Widget****Event and their corresponding serializers.

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Is this something we want to have in the next release/months, i.e. P2? Or is it closer to a nice-to-have (P3) speaking from now?

Comment 2

[Ben Hsu [:HoPang]]

IMHO, if we are going to launch Pointer Events in any form (i.e., pre-release), then it's P3 (nice-to-have); However, if we're not launching Pointer Events, then this issue has nothing to do with the very next release ;P

Comment 3

[Ming-Chou Shih [:stone]]

In this stage, I think we can set this bug as nice-to-have

Comment 4

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Thanks!

Comment 5

[Ming-Chou Shih [:stone]]

Attachment: Part1: Refine WidgetPointerHelper

Comment 6

[Ming-Chou Shih [:stone]]

Attachment: Part2: Serialize WidgetPointerHelper in IPC message

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8814782 [details] [diff] [review]
Part2: Serialize WidgetPointerHelper in IPC message

> template<>
>+struct ParamTraits<mozilla::WidgetPointerHelper>
>+{
>+  typedef mozilla::WidgetPointerHelper paramType;
>+
>+  static void Write(Message* aMsg, const paramType& aParam)
>+  {
>+    WriteParam(aMsg, aParam.pointerId);
>+    WriteParam(aMsg, aParam.tiltX);
>+    WriteParam(aMsg, aParam.tiltY);
>+    // We don't serialize convertToPointer and retargetedByPointerCapture since
>+    // they are temporarily variable and sould be reset to default.
s/sould/should/

Comment 8

[Ming-Chou Shih [:stone]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d870754296742552e2acc1979de1dee6fee9c7b

Comment 9

[Ming-Chou Shih [:stone]]

Attachment: Part1: Refine WidgetPointerHelper. r=smaug

Updated the patch summary.

Comment 10

[Ming-Chou Shih [:stone]]

Attachment: Part2: Serialize WidgetPointerHelper in IPC messag. r=smaug

Updated the patch summary and comments.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fd2c8004db8a
Part1: Refine WidgetPointerHelper. r=smaug
https://hg.mozilla.org/integration/mozilla-inbound/rev/eece9df96e36
Part2: Serialize WidgetPointerHelper in IPC messag. r=smaug

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/fd2c8004db8a
https://hg.mozilla.org/mozilla-central/rev/eece9df96e36