Closed
Bug 1299204
Opened 8 years ago
Closed 8 years ago
Force GC/CC in reftests since we can't figure out why nothing works
Categories
(Core :: JavaScript: GC, defect)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla51
Tracking | Status | |
---|---|---|
firefox51 | --- | fixed |
People
(Reporter: terrence, Assigned: terrence)
References
Details
Attachments
(1 file)
1.78 KB,
patch
|
mchang
:
review+
|
Details | Diff | Splinter Review |
This is a last resort. Things that fix the problem for me locally time out on try and hacks that hide the problem on try quadruple my test times locally. Hopefully just forcing a GC/CC occasionally will keep the overheads low enough that tests can at least complete everywhere while we investigate the root cause. At least, it worked for me when I tried it a month ago.
Attachment #8786396 -
Flags: review?(mchang)
Comment 1•8 years ago
|
||
Comment on attachment 8786396 [details] [diff] [review]
force_gc_cc_in_reftests-v0.diff
Review of attachment 8786396 [details] [diff] [review]:
-----------------------------------------------------------------
::: layout/tools/reftest/reftest-content.js
@@ +45,1 @@
>
nit: add a comment saying this runs for both the content and parent process. We had a comment in the other CC bug. Thanks!
Attachment #8786396 -
Flags: review?(mchang) → review+
Assignee | ||
Comment 2•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/4558fc3a712042f288ed2999bbc55410dfe4a224
Bug 1299204 - Do GC and CC even more aggressively in reftests; r=mchang
Comment 3•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in
before you can comment on or make changes to this bug.
Description
•