Closed Bug 1299309 Opened 8 years ago Closed 6 years ago

[webvr] VRDisplay.requestPresent must resolve fail the returned promise when Oculus DX11 resources can't be allocated

Categories

(Core :: WebVR, defect)

Product:
Core
Component:
WebVR
Platform:
Unspecified
Windows
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: kip, Assigned: kip)

References

Details

(Whiteboard: [webvr]) 

As described in Bug 1297105, an out of bounds array access occurs in VRDisplayOculus::GetNextRenderTarget().  This occurs when the DX11 resources fail to be allocated in VRDisplayOculus::StartPresentation().

The patch for Bug 1297105 will avoid the crash, but will result in failed sites being unaware that the VR presentation is not visible in the headset.

The intent of this bug is to ensure that the promise returned by VRDisplay.requestPresent will be resolved with a fail in the event that the DX11 resource allocation does not succeed.
Whiteboard: [webvr]
Component: Graphics → WebVR
With the VRService thread implementation, which has recently been turned on by default, the VRDisplay itself will no longer be created if the DX11 resource allocation fails.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.