Closed Bug 1299330 Opened 3 years ago Closed 3 years ago
Buffer Object .cpp:560:74: error: 'mremap' was not declared in this scope
58 bytes, text/x-review-board-request
NetBSD has mremap()  but according to FreeBSD bug  has different semantics and, unlike Linux, has |void *newp| as the 3rd argument, not 5th. Other BSDs and Solaris don't implement mremap(). Looking at the code OS X cheat can probably be extended for any 64bit system that's neither Windows nor Linux. In file included from js/src/Unified_cpp_js_src30.cpp:20: js/src/vm/ArrayBufferObject.cpp:560:27: error: use of undeclared identifier 'mremap' if (MAP_FAILED == mremap(dataPointer(), mappedSize_, newMapped, 0)) ^ 1 error generated.  http://netbsd.gw.com/cgi-bin/man-cgi?mremap++NetBSD-current  https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=59912
Comment on attachment 8786551 [details] Bug 1299330 - Unbreak build on BSDs after bug 1287967. https://reviewboard.mozilla.org/r/75468/#review73436 Ah, thanks!
Attachment #8786551 - Flags: review?(luke) → review+
Thanks a lot jan for handling it...
The build on OpenBSD fails elsewhere (CanvasRenderingContext2D.cpp:1631:17: error: expected value in expression #if USE_SKIA_GPU) but with your diff js builds fine.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/bccb467cbc4f Unbreak build on BSDs after bug 1287967. r=luke
You need to log in before you can comment on or make changes to this bug.