If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

If a homepage is set, it should be displayed at the end of the welcome wizard

RESOLVED FIXED in Firefox 48

Status

()

Firefox for Android
Distributions
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: mkaply, Assigned: mkaply)

Tracking

Trunk
Firefox 51
Points:
---

Firefox Tracking Flags

(firefox48 fixed, firefox49 fixed, firefox50 fixed, firefox51 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
Currently when you click "Start browsing" at the end of the welcome wizard, it goes straight to the URL bar for editing.

If you have a homepage, it should show at the end of the wizard.
(Assignee)

Comment 1

a year ago
Created attachment 8786561 [details] [diff] [review]
Only enter edit mode if there is no homepage

This should really only affect distributions because they would have a homepage set when the wizard appears.
Assignee: nobody → mozilla
Status: NEW → ASSIGNED
Attachment #8786561 - Flags: review?(rnewman)
Comment on attachment 8786561 [details] [diff] [review]
Only enter edit mode if there is no homepage

Review of attachment 8786561 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/java/org/mozilla/gecko/BrowserApp.java
@@ +2751,5 @@
>              mFirstrunAnimationContainer.registerOnFinishListener(new FirstrunAnimationContainer.OnFinishListener() {
>                  @Override
>                  public void onFinish() {
> +                    if (mFirstrunAnimationContainer.showBrowserHint() &&
> +                        TextUtils.isEmpty(getHomepage())) {

This does I/O unless it's already been run, and if it's already been run it'll be as a side-effect (e.g., of telemetry).

Are you confident that this won't spew strictmode warnings?
Attachment #8786561 - Flags: review?(rnewman) → review+
(Assignee)

Comment 3

a year ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/91956c5e327190081112ece804cb3ddfeee36e5a
Bug 1299350 - If there is a homepage, show it at the end of the wizard. r=rnewman
(Assignee)

Comment 4

a year ago
Comment on attachment 8786561 [details] [diff] [review]
Only enter edit mode if there is no homepage

Approval Request Comment
[Feature/regressing bug #]: Wizard should navigate to homepage at the end.
[User impact if declined]: At end of wizard, partner homepage doesn't show.
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: Low - only applies for distributions (homepage at startup)
[String/UUID change made/needed]: None

I am asking for this for release because we are looking to have a one off done for a partner with this fix and bug 1299162
Attachment #8786561 - Flags: approval-mozilla-release?
Attachment #8786561 - Flags: approval-mozilla-beta?
Attachment #8786561 - Flags: approval-mozilla-aurora?

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/91956c5e3271
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox51: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51

Comment 6

a year ago
This should really only affect distributions because they would have a homepage set when the wizard appears. So I'm changing the component.
Component: General → Distributions

Updated

a year ago
status-firefox48: --- → affected
status-firefox49: --- → affected
status-firefox50: --- → affected
Hi Mike, could you please comment on the test coverage section of the uplift request? Are there automated tests for this already? If not, did you manually test it?
Flags: needinfo?(mozilla)
(Assignee)

Comment 8

a year ago
> Hi Mike, could you please comment on the test coverage section of the uplift request? Are there automated tests for this already? If not, did you manually test it?

It has been manually tested by me and by the partner. Unfortunately it is a difficult solution to test as it requires a rooted device with a homepage set in the distribution, so it cannot be automated.
Flags: needinfo?(mozilla)
https://hg.mozilla.org/releases/mozilla-release/rev/43f96302c08f
status-firefox48: affected → fixed
Comment on attachment 8786561 [details] [diff] [review]
Only enter edit mode if there is no homepage

Last minute fix for welcome screen for partner deal. 
Let's do it.
Attachment #8786561 - Flags: approval-mozilla-release?
Attachment #8786561 - Flags: approval-mozilla-release+
Attachment #8786561 - Flags: approval-mozilla-beta?
Attachment #8786561 - Flags: approval-mozilla-beta+
Attachment #8786561 - Flags: approval-mozilla-aurora?
Attachment #8786561 - Flags: approval-mozilla-aurora+

Comment 11

a year ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/92ea0f08b49c
https://hg.mozilla.org/releases/mozilla-beta/rev/101e643d0f73
status-firefox49: affected → fixed

Comment 12

a year ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/1dd122df9806
status-firefox50: affected → fixed
You need to log in before you can comment on or make changes to this bug.