If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Baldr: change handling of !HaveCompilerSUpport

RESOLVED FIXED in Firefox 51

Status

()

Core
JavaScript Engine
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: luke, Assigned: luke)

Tracking

Trunk
mozilla51
Points:
---

Firefox Tracking Flags

(firefox51 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
Created attachment 8786591 [details] [diff] [review]
change-compiler-support

This patch changes the case where !HaveCompilerSupport() to not add the WebAssembly object instead of having its methods throw.  This seem wholly better since that way code will naturally fall into the "don't have wasm path".
Attachment #8786591 - Flags: review?(bbouvier)
Will this mean that when wasm is released, machines that don't support it won't even see the WebAssembly object? If so, it sounds like a behavior that should be constant across browsers and ought to be standardized. Is it the case?
(Assignee)

Comment 2

a year ago
That's right.  This is consistent with when a Web API is released that hasn't been implemented for all platforms, so it's not really part of the standard, it just represents NYI.  The difference with the current state is that the plain feature-detection `this["WebAssembly"]` which likely sites would already be doing would work instead of getting some weird exception.  I think eventually we'll get a wasm interpreter and, when that happens, we'd support WebAssembly on all platforms.
Comment on attachment 8786591 [details] [diff] [review]
change-compiler-support

Review of attachment 8786591 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the explanation! Agreed on irc that fuzzers shouldn't hit this, so this should not be an issue for differential testing in particular.
Attachment #8786591 - Flags: review?(bbouvier) → review+

Comment 4

a year ago
Pushed by lwagner@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/edc6d676d4d7
Baldr: change handling of when not HaveCompilerSupport (r=bbouvier)

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/edc6d676d4d7
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox51: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.