|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
58 bytes, text/x-review-board-request
|Details | Review|
Near as I can tell, we have exactly one knob (other than SETA) to adjust coalescing, https://dxr.mozilla.org/build-central/source/buildbotcustom/misc.py#399 Since that's a teeny tiny number (SETA's numbers are 7 for everything except WinXP, where it's 14), the bug 1296329 experiment of disabling SETA for WinXP to get away from the effects of SETA's bug 1299377 misbehavior isn't really getting a chance to do anything much. We just finished a 3 hour tree closure for the backlog of both WinXP (currently coalescing) and Win8 (currently SETA), so we really can't do ourselves too much harm by increasing the coalescing threshold. Personally, I'd set it to 8 because that's what I thought it was, probably from what it was sometime long ago, but even 5 would help to give us a chance of avoiding daily backlog closures.
+1 3 was conservative. Specially since there was not a tool to backfill at the time it was defined. catlee: who could look into this and bug 1299377?
This is an extremely easy patch for someone to do, I'll happily review :) I think bumping to 8 is fine. We have much better tools these days for bisecting in case of failure, right?
Comment on attachment 8787472 [details] Bug 1299378 - Increase the number of jobs which can be coalesced to 8 instead of 3. https://reviewboard.mozilla.org/r/76224/#review74408
Attachment #8787472 - Flags: review?(catlee) → review+
https://hg.mozilla.org/build/buildbotcustom/rev/515987988fd4b9855661c5733708fa8fb24aa0b9 Bug 1299378 - Increase the number of jobs which can be coalesced to 8 instead of 3. r=catlee
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.