Closed Bug 1299445 Opened 4 years ago Closed 4 years ago

Allow distribution.ini to toggle automigration code for Funnelcakes 87/88 49.0

Categories

(Firefox :: Migration, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 51
Tracking Status
firefox49 --- fixed
firefox50 --- fixed
firefox51 --- fixed

People

(Reporter: Gijs, Assigned: Gijs)

References

Details

Attachments

(1 file)

See bug 1295873 comment 11 and earlier. Basically, the pref flip from distribution.ini doesn't take effect early enough to be able to toggle it directly from a funnelcake (sigh).

Because uplifting a patch specifically for this is probably less work / risk than having to do a separate branch on release to deal with this, going to write a patch so we can use distribution.ini directly from this code, assuming that there's good way of doing so (which bug 1295873 suggests there is).
Comment on attachment 8786731 [details]
Bug 1299445 - use distribution.ini directly to check if automigration is enabled,

https://reviewboard.mozilla.org/r/75652/#review73572
Attachment #8786731 - Flags: review?(mozilla) → review+
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/106601691ea7
use distribution.ini directly to check if automigration is enabled, r=mkaply
https://hg.mozilla.org/mozilla-central/rev/106601691ea7
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Comment on attachment 8786731 [details]
Bug 1299445 - use distribution.ini directly to check if automigration is enabled,

Approval Request Comment
[Feature/regressing bug #]: automigration funnelcakes 87/88 (bug 1295873)
[User impact if declined]: we'd have to do a separate (code-modified) build for the funnelcake rather than just being able to use distribution.ini and a repack.
[Describe test coverage new/current, TreeHerder]: the code here is touched by the automated test for the automigration (I broke the test in an initial version of the patch!) but ultimately we should also manually test that toggling the pref in distribution.ini does work. I did that when I wrote the patch, of course, but we should verify this on beta/release.
[Risks and why]: low risk. Certainly lower risk and less work than having to do custom builds for the funnelcake.
[String/UUID change made/needed]: nope
Attachment #8786731 - Flags: approval-mozilla-beta?
Attachment #8786731 - Flags: approval-mozilla-aurora?
Comment on attachment 8786731 [details]
Bug 1299445 - use distribution.ini directly to check if automigration is enabled,

Sounds useful for funnelcake experiment in 49, let's take it.
Attachment #8786731 - Flags: approval-mozilla-beta?
Attachment #8786731 - Flags: approval-mozilla-beta+
Attachment #8786731 - Flags: approval-mozilla-aurora?
Attachment #8786731 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.