[B2G OS - flamingo] blob extraction process creates "backup-tianchi" folder instead of "backup-flamingo"

RESOLVED FIXED

Status

Firefox OS
GonkIntegration
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: Enrico, Assigned: Enrico)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

59 bytes, text/x-github-pull-request
gerard
: review+
Details | Review | Splinter Review
(Assignee)

Description

a year ago
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:49.0) Gecko/20100101 Firefox/49.0
Build ID: 20160829102229

Steps to reproduce:

Build for flamingo, as per instructios on MDN. In particular, `./config.sh flamingo-l` and `./build.sh`


Actual results:

The build process creates a folder `backup-tianchi`.


Expected results:

The folder should be named `backup-flamingo`
(Assignee)

Comment 1

a year ago
patch proposed with PR <https://github.com/mozilla-b2g/device-sony-flamingo>
(Assignee)

Comment 2

a year ago
correct link: <https://github.com/mozilla-b2g/device-sony-flamingo/pull/13>
Thanks Enrico, there is a little of work to do to make this right:
 - attach your link to the PR as a text attachment to this bug
 - make your commit follow the rule: "Bug XXX - Description r=gerard-majax"
 - on the attached link set the review flag to me
Flags: needinfo?(enrico.ghiorzi)
Assignee: nobody → enrico.ghiorzi
Component: General → GonkIntegration
(Assignee)

Comment 4

a year ago
Created attachment 8786747 [details] [review]
Fix device name for flamingo

Link to the PR.
(Assignee)

Updated

a year ago
Attachment #8786747 - Flags: review+
(Assignee)

Updated

a year ago
Attachment #8786747 - Attachment is patch: true
Attachment #8786747 - Attachment mime type: text/x-github-pull-request → text/plain
Attachment #8786747 - Flags: review+ → review?(lissyx+mozillians)
(Assignee)

Updated

a year ago
Attachment #8786747 - Attachment is patch: false
(Assignee)

Updated

a year ago
Attachment #8786747 - Attachment mime type: text/plain → text/link
(Assignee)

Updated

a year ago
Attachment #8786747 - Attachment mime type: text/link → text/x-github-pull-request
(Assignee)

Comment 5

a year ago
Ok, it should be alright now…
Comment on attachment 8786747 [details] [review]
Fix device name for flamingo

Perfect, thanks !
Flags: needinfo?(enrico.ghiorzi)
Attachment #8786747 - Flags: review?(lissyx+mozillians) → review+
https://github.com/mozilla-b2g/device-sony-flamingo/commit/3ac533d819e32c75cfa205a107446d67d0b4e4db
Status: UNCONFIRMED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
(Assignee)

Comment 8

a year ago
Great, thanks!
You need to log in before you can comment on or make changes to this bug.