1299482 - Fix direction of tooltip for frame-link-source-inner in Web/Browser Console with RTL locales

Status: NEW

(DevTools :: Console, defect, P5)

Description

[magicp]

Attachment: fix-direction-of-tooltip-for-frame-link-source-inner-in-console.png

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID: 20160830030201

Steps to reproduce:

1. Start Nightly in RTL locales (e.g. Arabic)
2. Go to "Getting Started" (https://www.mozilla.org/en-US/firefox/central/)
3. Open Web Console (Ctrl+Shift+K)
4. Hover mouse on frame-link-source-inner


Actual results:

Tooltip direction is LTR in RTL locales. And also the left arrow is mismatched.

Regression range:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=a0a49732aeb4ca43fa98c37cecc0c9fec5303e01&tochange=d912055f8e8ad75d189bd480017fdb5a33ee4d7e


Expected results:

Tooltip direction should be RTL.

Comment 1

[Brian Grinstead [:bgrins]]

This change was intentional to fix two issues in Bug 1286844 - the tooltip wouldn't show up on first hover and it was misaligned.  If someone could figure out how to allow RTL inside the tooltip without reintroducing those bugs I'd accept a patch.

Comment 2

[magicp]

(In reply to Brian Grinstead [:bgrins] from comment #1)
> This change was intentional to fix two issues in Bug 1286844 - the tooltip
> wouldn't show up on first hover and it was misaligned.  If someone could
> figure out how to allow RTL inside the tooltip without reintroducing those
> bugs I'd accept a patch.

However, Bug 1286844 is not fixed in RTL locales. How about this?

Comment 3

[Brian Grinstead [:bgrins]]

(In reply to magicp from comment #2)
> (In reply to Brian Grinstead [:bgrins] from comment #1)
> > This change was intentional to fix two issues in Bug 1286844 - the tooltip
> > wouldn't show up on first hover and it was misaligned.  If someone could
> > figure out how to allow RTL inside the tooltip without reintroducing those
> > bugs I'd accept a patch.
> 
> However, Bug 1286844 is not fixed in RTL locales. How about this?

The tooltip is forced into LTR in both LTR and RTL locales to fix the 2 issues mentioned in Comment 1.  There shouldn't be the hover or layout bug in RTL anymore. If there's a way to switch to RTL and keep those two issues fixed then that would be good