Closed Bug 1299509 Opened 5 years ago Closed 4 years ago

Run the clang static analysis everywhere

Categories

(Firefox Build System :: Source Code Analysis, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: nika, Unassigned)

References

Details

This means making it easy to run locally as part of a user's workflow, so that we can add tests which fail more aggressively.

We really don't want to write static analysis passes which cause people's code to fail when they try to land it, even though it worked fine locally, if we can help it. Ideally we would make the clang plugin part of every user's toolkit, so that they run and discover the SA failures locally before pushing to try or trying to land.
We are working on the integration of static analyzer in mozreview, this is not exactly that you are asking but it will help!
No longer blocks: 1299489
Blocks: 1223932
Depends on: 1428158
Product: Core → Firefox Build System
Can this be closed since now we have the following:
1. Mozreview static analysis for cpp 
2. Mach static analysis by doing mach static-analysis check ....

All of the 2 implementations use clang-tidy alongside our checkers implemented in build/clang-plugin.
Flags: needinfo?(nika)
\o/ Thanks for your awesome work andi & sylvestre :-)
Status: NEW → RESOLVED
Closed: 4 years ago
Flags: needinfo?(nika)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.