1299556 - Move the EmojiOneMozilla.ttf font to somewhere more easily usable by SeaMonkey and Thunderbird

Status: RESOLVED WONTFIX

(Toolkit :: General, defect, P5)

Description

[Philip Chee]

Bug 1231701 put the EmojiOneMozilla font in Firefox /browser/fonts/
Please consider moving it to somewhere easier to include for non Firefox applications such as SeaMonkey and Thunderbird.

Perhaps /gfx/fonts/ ?

Comment 1

[:Gijs (he/him)]

I'd review a patch but this is not P2 for the Firefox team.

Comment 2

[Philip Chee]

Attachment: Patch to move EmojiOneMozilla.ttf to /gfx/

Try job: https://treeherder.mozilla.org/#/jobs?repo=try&revision=cef4a23e7317a0c03ccbc32534dea2b5465ea43a

Loaded some test pages:
http://www.fileformat.info/info/emoji/browsertest.htm
http://apps.timwhitlock.info/emoji/tables/unicode

Comment 3

[:Gijs (he/him)]

Comment on attachment 8787318 [details] [diff] [review]
Patch to move EmojiOneMozilla.ttf to /gfx/

Review of attachment 8787318 [details] [diff] [review]:
-----------------------------------------------------------------

This is basically a build patch, so s/me/glandium for review. AIUI this doesn't change where in the package the files end up for Firefox, so that seems OK to me.

(Sorry, when I said "I" would review, I guess I meant "we would", as appropriate, and that I personally was not opposed to taking a patch. But I shouldn't review the moz.build changes to gfx/fonts/ here.)

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 8787318 [details] [diff] [review]
Patch to move EmojiOneMozilla.ttf to /gfx/

Review of attachment 8787318 [details] [diff] [review]:
-----------------------------------------------------------------

This is more of a module ownership thing than a build thing. The recipient module of the file needs to be okay with the file being in their module, and where. I'm not particularly convinced gfx is the right module for this. I'd say this font fits more in the same module as the html resource files (resource://gre/res), but I'm not a module authority.

Now, as for the build side of things, this essentially makes the file copied to dist/bin/fonts for every application, and that may not be desired.

With all that said, I don't see why moving the font makes it easily usable by comm-central: You can just add DIRS += ['/browser/fonts'] in any moz.build file in comm-central, and that should work.

Comment 5

[Philip Chee]

OK Thanks!