Closed Bug 1299580 Opened 3 years ago Closed 3 years ago

Remove unused localized strings from *.properties files

Categories

(DevTools :: General, defect)

defect
Not set

Tracking

(firefox51 fixed)

RESOLVED FIXED
Firefox 51
Tracking Status
firefox51 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

Details

Attachments

(2 files, 5 obsolete files)

While working on various localization bugs, I stumbled upon a few unused strings that should be removed from the codebase.
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Attachment #8786877 - Attachment is obsolete: true
Attachment #8786879 - Attachment is obsolete: true
Try push : https://treeherder.mozilla.org/#/jobs?repo=try&revision=12c00dae4e19 (patches were splitted differently but content is the same)

I used a script to help me identify potentially unused keys, basically splitting keys on "." and checking for occurrences of the substring in our codebase. For each key found that way I tried to see if there was any way the substring got created by concatenation. If not the string ended up in a patch here, but I might very well have missed something.
Comment on attachment 8786878 [details]
Bug 1299580 - Remove unused localized strings from animationinspector;

https://reviewboard.mozilla.org/r/75756/#review73906

Thanks for the cleanup.
Attachment #8786878 - Flags: review?(pbrosset) → review+
Comment on attachment 8786880 [details]
Bug 1299580 - Remove unused string from storage.properties file;

https://reviewboard.mozilla.org/r/75760/#review73908

Double checked and these strings don't appear to be used anywhere.
Attachment #8786880 - Flags: review?(mratcliffe) → review+
Comment on attachment 8786876 [details]
Bug 1299580 - Remove unused localized strings from inspector and styleeditor;

https://reviewboard.mozilla.org/r/75752/#review74082
Attachment #8786876 - Flags: review?(gl) → review+
Comment on attachment 8786881 [details]
Bug 1299580 - Remove unused localized strings from webconsole;

https://reviewboard.mozilla.org/r/75762/#review74086
Attachment #8786881 - Flags: review?(bgrinstead) → review+
Thanks for the reviews all! Will land the already reviewed patches since I have other bugs that touch properties files waiting :)
Keywords: leave-open
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/76520bbe54ab
Remove unused localized strings from webaudioeditor, scratchpad, appcacheutils;r=miker
https://hg.mozilla.org/integration/fx-team/rev/bbbe4bcd758d
Remove unused localized strings from inspector and styleeditor;r=gl
https://hg.mozilla.org/integration/fx-team/rev/891fcabf052b
Remove unused localized strings from animationinspector;r=pbro
https://hg.mozilla.org/integration/fx-team/rev/884f60cd86d3
Remove unused localized strings from webconsole;r=bgrins
Comment on attachment 8786882 [details]
Bug 1299580 - Remove unused localized strings from debugger;

https://reviewboard.mozilla.org/r/75764/#review74544
Attachment #8786882 - Flags: review?(jlong) → review+
Attachment #8786876 - Attachment is obsolete: true
Attachment #8786878 - Attachment is obsolete: true
Attachment #8786881 - Attachment is obsolete: true
Comment on attachment 8786880 [details]
Bug 1299580 - Remove unused string from storage.properties file;

https://reviewboard.mozilla.org/r/75760/#review74872
Attachment #8786880 - Flags: review?(francesco.lodolo) → review+
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/aae782f76e3d
Remove unused localized strings from debugger;r=jlongster
https://hg.mozilla.org/integration/fx-team/rev/22565d35ed35
Remove unused string from storage.properties file;r=flod
Keywords: leave-open
https://hg.mozilla.org/mozilla-central/rev/aae782f76e3d
https://hg.mozilla.org/mozilla-central/rev/22565d35ed35
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.