1299599 - Sometimes interactive loaner homepage says "Waiting for Loaner" even though the task has finished setup

Status: RESOLVED FIXED

(Taskcluster :: UI, defect)

Description

[Andrew Halberstadt [:ahal]]

STR:
1) Checkout a 1-click loaner
2) Open task, go to run tab and observe log
3) Notice when task finishes setup
4) Go back to loaner home page and notice it is still waiting
5) Wait until the 5 minute window closes and the task gets resolved

I'm not 100% sure when this started happening. I think I saw it yesterday too, but thought I had just missed the desktop notification. I'm also not sure if this is intermittent or 100% reproducible.

Comment 1

[Andrew Halberstadt [:ahal]]

I just tried again and it worked. So must be intermittent or some kind of transient error. I'll try to reproduce again and paste actual logs this time.

Comment 2

[Andrew Halberstadt [:ahal]]

After 5 more unsuccessful attempts trying to reproduce, I'm giving up. I guess I'll leave the bug here in case it happens again. For the record, I did reproduce this issue twice in a row though.

Comment 3

[Andrew Halberstadt [:ahal]]

Attachment: Screenshot from 2016-09-02 10-11-51.png

It happened again. Here's a screenshot, with loaner home page on the left (still waiting) and task log on the right. In the log, the test-ubuntu.sh script has got to the end, so normally the homepage would say "Ready" by that point. The loaner homepage just stays like that until it says "Task resolved".

I still have no idea what causes this to happen. The next time I retried the same task, it worked just fine.

Comment 4

[Greg Arndt [:garndt]]

Jonas, what is it using to determine that it's ready?  Maybe somehow there is a hiccup there?

Comment 5

[Andrew Halberstadt [:ahal]]

Attachment: Log of task where this happened

And here's a full log from a task where this happened. I don't see anything overtly suspicious.

Comment 6

[Jonas Finnemann Jensen (:jonasfj)]

There is a race condition between:
 A) Listing artifacts from queue
 B) Setting up event handler listening for new artifacts

As this is user-facing UI, I really didn't think it would be an issue. But I guess we really are hitting it.
I've seen once or twice myself..

Fix in https://github.com/taskcluster/taskcluster-tools/pull/135

Comment 7

[[github robot]]

Commits pushed to master at https://github.com/taskcluster/taskcluster-tools

https://github.com/taskcluster/taskcluster-tools/commit/ed3fa27d4c3436c501b7b68c1106433fec3efbe9
Fix bug 1299599 - race condition between listing artifacts and listening for events

https://github.com/taskcluster/taskcluster-tools/commit/965c9b4ceb9c8037c22a497693b171e519877e25
Merge pull request #135 from taskcluster/fix-1299599

Fix bug 1299599 - race condition between listing artifacts and listen…