Closed
Bug 1299613
Opened 5 years ago
Closed 5 years ago
Grab ref to closingButton name prior to closing
Categories
(Firefox :: Preferences, defect)
Firefox
Preferences
Tracking
()
RESOLVED
FIXED
Firefox 51
| Tracking | Status | |
|---|---|---|
| firefox51 | --- | fixed |
People
(Reporter: erahm, Assigned: erahm)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
2.28 KB,
patch
|
Gijs
:
review+
|
Details | Diff | Splinter Review |
This fixes fallout from bug 1276366 which caused failures in browser_subdialogs.js. In order to avoid poking a potentially dead wrapper we grab a ref to the button name prior to being destroyed.
|
Assignee | |
Comment 1•5 years ago
|
||
Attachment #8786923 -
Flags: review?(gijskruitbosch+bugs)
|
|
Assignee | |
Comment 2•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7a6a45426cc3
|
||
Comment 3•5 years ago
|
||
Comment on attachment 8786923 [details] [diff] [review] Grab ref to closingButton name prior to closing Review of attachment 8786923 [details] [diff] [review]: ----------------------------------------------------------------- rs=me
Attachment #8786923 -
Flags: review?(gijskruitbosch+bugs) → review+
|
|
Assignee | |
Comment 4•5 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/146e402be57e5c6fb052e0c1e2e7f781a4b4345e Bug 1299613 - Grab ref to closingButton name prior to closing. r=Gijs
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/146e402be57e
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
You need to log in
before you can comment on or make changes to this bug.
Description
•