Closed Bug 1299613 Opened 5 years ago Closed 5 years ago

Grab ref to closingButton name prior to closing

Categories

(Firefox :: Preferences, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 51
Tracking Status
firefox51 --- fixed

People

(Reporter: erahm, Assigned: erahm)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

This fixes fallout from bug 1276366 which caused failures in browser_subdialogs.js.

In order to avoid poking a potentially dead wrapper we grab a ref to the
button name prior to being destroyed.
Attachment #8786923 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 8786923 [details] [diff] [review]
Grab ref to closingButton name prior to closing

Review of attachment 8786923 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me
Attachment #8786923 - Flags: review?(gijskruitbosch+bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/146e402be57e
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
You need to log in before you can comment on or make changes to this bug.