Grab ref to closingButton name prior to closing

RESOLVED FIXED in Firefox 51

Status

()

Product:
Firefox
Component:
Preferences
Type:
defect
Status:
RESOLVED FIXED
Opened:
3 years ago
Updated:
3 years ago

People

(Reporter: erahm, Assigned: erahm)

Tracking

(Blocks 1 bug)

Version:
unspecified
Target:
Firefox 51
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox51 fixed)

Details

Attachments

(1 attachment)

Grab ref to closingButton name prior to closing
2.28 KB, patch
Gijs
: review+
Details | Diff | Splinter Review 
This fixes fallout from bug 1276366 which caused failures in browser_subdialogs.js.

In order to avoid poking a potentially dead wrapper we grab a ref to the
button name prior to being destroyed.
Attachment #8786923 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 8786923 [details] [diff] [review]
Grab ref to closingButton name prior to closing

Review of attachment 8786923 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me
Attachment #8786923 - Flags: review?(gijskruitbosch+bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/146e402be57e
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
You need to log in before you can comment on or make changes to this bug.