1299618 - UnicodeEncodeError on Windows when running |mach lint|

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, defect)

Description

[Andrew Halberstadt [:ahal]]

Regression from bug 1258341. Technically this has been broken for awhile, but apparently no one has tried running |mach lint| on Windows until now.

It seems like the msys shell just isn't capable of handling unicode. I have a patch that at least causes the command to *not fail*. Though the 'x' at the end of the output shows up garbled. I don't think it's worth much time trying to fix it further though.

A workaround to this until it lands is:
export PYTHONIOENCODING=UTF-8

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1299618 - [mozlint] Encode results to utf-8 before printing to stdout,

Review commit: https://reviewboard.mozilla.org/r/75882/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/75882/

Comment 2

[Andrew Halberstadt [:ahal]]

Note: even after this patch instead of the unicode 'x', users will see some garbage text. But at least they'll be able to run |mach lint|. So we should land this patch for now and deal with actually getting the 'x' to display properly later. Or more likely, just not print unicode in the first place when on msys.

Comment 3

[Steven MacLeod [:smacleod]]

Comment on attachment 8787036 [details]
Bug 1299618 - [mozlint] Encode results to utf-8 before printing to stdout,

https://reviewboard.mozilla.org/r/75882/#review74012

::: python/mozlint/mozlint/cli.py:104
(Diff revision 1)
>  
>      # run all linters
>      results = lint.roll(paths, rev=rev, workdir=workdir)
>  
>      formatter = formatters.get(fmt)
> -    print(formatter(results))
> +    print(formatter(results).encode('utf-8', 'replace'))

Can you add a comment note about the problems with this partial solution?

Comment 4

[Andrew Halberstadt [:ahal]]

Comment on attachment 8787036 [details]
Bug 1299618 - [mozlint] Encode results to utf-8 before printing to stdout,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/75882/diff/1-2/

Comment 5

[Andrew Halberstadt [:ahal]]

Comment on attachment 8787036 [details]
Bug 1299618 - [mozlint] Encode results to utf-8 before printing to stdout,

https://reviewboard.mozilla.org/r/75880/#review74126

Tested on try here:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ecd4a45235011d232a275841b3e804b6efb1ef11

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eeba75f09439
[mozlint] Encode results to utf-8 before printing to stdout, r=smacleod

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/eeba75f09439