Closed Bug 1299642 Opened 4 years ago Closed 4 years ago

Fix docshell errors when breaking chrome -> chrome leaks

Categories

(Testing :: Mochitest, defect)

defect
Not set

Tracking

(firefox51 fixed)

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: erahm, Assigned: erahm)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

This is fallout from bug 1276366.

It appears the lambda function passed to waitForFocus goes out of
scope when the window is closed. Just pass in SimpleTest.finish
directly instead.
Ted it seems you've reviewed things here in the past, but feel free to redirect.
Attachment #8786965 - Flags: review?(ted)
Comment on attachment 8786965 [details] [diff] [review]
Fix docshell errors when breaking chrome -> chrome leaks

Review of attachment 8786965 [details] [diff] [review]:
-----------------------------------------------------------------

Boy, that is terrible.
Attachment #8786965 - Flags: review?(ted) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/1040858d0fb6e42de9f2d06bbb1daf800db7146a
Bug 1299642 - Fix docshell errors when breaking chrome -> chrome leaks. r=ted
https://hg.mozilla.org/mozilla-central/rev/1040858d0fb6
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.