Closed Bug 1299653 Opened 3 years ago Closed 2 years ago

Intermittent toolkit/components/narrate/test/browser_narrate_disable.js | Found a tab after previous test timed out: about:blank | Assertion failure: aCode == MsgDropped (Processing error in CompositorBridgeChild), at ipc/CompositorBridgeChild.cpp:1066

Categories

(Core :: IPC, defect, P3)

Product:
Core
Component:
IPC
Type:
defect

Tracking

()

Status:
RESOLVED INCOMPLETE
Tracking Flags:
Tracking Status
firefox50 --- affected
firefox51 --- affected

People

(Reporter: intermittent-bug-filer, Unassigned)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Bug 1299653 - Don't have the page scrolling when the tab is closed.
58 bytes, text/x-review-board-request
jaws
: review+
Details
Component: General → IPC
Product: Toolkit → Core
Bulk assigning P3 to all open intermittent bugs without a priority set in Firefox components per bug 1298978.
Priority: -- → P3
Flags: needinfo?(eitan)
Assignee: nobody → eitan
Flags: needinfo?(eitan)
From the stack, this looks like a layout issue. I think the tab is closed mid-scroll and some IPC messages get missed.

I can probably remedy this test by guaranteeing we are not scrolling by the end of it..
(In reply to Eitan Isaacson [:eeejay] from comment #2)
> From the stack, this looks like a layout issue. I think the tab is closed
> mid-scroll and some IPC messages get missed.
> 
> I can probably remedy this test by guaranteeing we are not scrolling by the
> end of it..

Can this case happen in actual browser usage?
(In reply to Jed Davis [:jld] {⏰UTC-6} from comment #5)
> (In reply to Eitan Isaacson [:eeejay] from comment #2)
> > From the stack, this looks like a layout issue. I think the tab is closed
> > mid-scroll and some IPC messages get missed.
> > 
> > I can probably remedy this test by guaranteeing we are not scrolling by the
> > end of it..
> 
> Can this case happen in actual browser usage?

I'm assuming so. To clarify this is an assertion failure in debug builds, not an actual segmentation fault.
Comment on attachment 8787913 [details]
Bug 1299653 - Don't have the page scrolling when the tab is closed.

https://reviewboard.mozilla.org/r/76504/#review75180
Attachment #8787913 - Flags: review?(jaws) → review+
Pushed by eisaacson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4266dca3ab7d
Don't have the page scrolling when the tab is closed. r=jaws
https://hg.mozilla.org/mozilla-central/rev/4266dca3ab7d
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox51: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
This is still failing.
Status: RESOLVED → REOPENED
status-firefox50: fixed → affected
status-firefox51: fixed → affected
Flags: needinfo?(eitan)
Resolution: FIXED → ---
Target Milestone: mozilla51 → ---
Wouldn't orange robot be posting here? Any links to failed tests?
David,

I tried working around this assertion, but looks like I failed. Do you have any clue why we are running into this?
Flags: needinfo?(eitan) → needinfo?(dvander)
We're hitting this case here [1], which means an async message's callback returned false. However CompositorBridgeChild doesn't have any methods which actually do that, so probably it was a routing or channel state problem, which would get deduced here [2].

To narrow down which case, I would log the message code in CompositorBridgeChild::OnProcessingError. You could also log the message ID in MessageChannel::DispatchAsyncMessage, which we'd want to know if this is a send-after-shutdown bug.

[1] http://searchfox.org/mozilla-central/rev/950e13cca1fda6507dc53c243295044e8eda4493/ipc/glue/MessageChannel.cpp#1664
[2] http://searchfox.org/mozilla-central/source/__GENERATED__/ipc/ipdl/PCompositorBridgeChild.cpp#1246
Flags: needinfo?(dvander)
Assignee: eitan → nobody
resolving this as we haven't seen it in almost a year.
Status: REOPENED → RESOLVED
Closed: 3 years ago → 2 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.