Closed Bug 1299690 Opened 4 years ago Closed 4 years ago

Disable rust for linux32 on firefox 49

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox48 wontfix, firefox49 fixed)

RESOLVED FIXED
Tracking Status
firefox48 --- wontfix
firefox49 --- fixed

People

(Reporter: rillian, Assigned: rillian)

References

Details

Attachments

(1 file)

We've seen a handful of crashes on linux32 because of the SSE2 requirement. We've dropped support for CPUs without SSE2 for win32, but didn't do the equivalent work to block updates for linux32.

The lowest-risk way to avoid those crashes is to turn off rust in official builds until we have a better support story.
A simple alternative option is to change the rust compiler build target.
[Tracking Requested - why for this release]:
Comment on attachment 8787018 [details]
Bug 1299690 - Disable rust for linux32 on Firefox 49.

This looks fine. Is glandium's suggestion hard to do? Or is there a reason that wouldn't work?
Attachment #8787018 - Flags: review?(mshal) → review+
Glandium's suggestion was my plan for 50 and 51. It's not hard to do, see bug 1299864.

I thought this would be more acceptable for beta uplift, and I thought the risk was similar. Glandium, would you prefer switching to the i586 target here?
Flags: needinfo?(mh+mozilla)
Comment on attachment 8787018 [details]
Bug 1299690 - Disable rust for linux32 on Firefox 49.

Approval Request Comment

[Feature/regressing bug #]: 1291650

[User impact if declined]: 32-bit Linux users on old AthlonXP system will experience crashes playing video.

[Describe test coverage new/current, TreeHerder]: Running without rust enabled is still tested on android.

[Risks and why]: There should be no effect other than loss of test data from this pilot project. We have said we would disable this code while it remains optional and would prefer not to break things for a few users this affects. If the patch does cause problems it should be obvious immediately, and as a one-line change we can revert and either accept the crashes or use the alternate i586 build target per bug 1299864.

[String/UUID change made/needed]: None.
Attachment #8787018 - Flags: approval-mozilla-beta?
Comment on attachment 8787018 [details]
Bug 1299690 - Disable rust for linux32 on Firefox 49.

Should avoid a linux32 crash, let's take this for the 49 RC build on Monday.
Attachment #8787018 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
(In reply to Ralph Giles (:rillian) needinfo me from comment #5)
> Glandium's suggestion was my plan for 50 and 51. It's not hard to do, see
> bug 1299864.
> 
> I thought this would be more acceptable for beta uplift, and I thought the
> risk was similar. Glandium, would you prefer switching to the i586 target
> here?

I don't have a preference.
Flags: needinfo?(mh+mozilla)
Ok, thanks. We'll go with this.
Closing. The same issue for Firefox 50 and 51 is addressed by bug 1299864.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.