Open Bug 1299707 Opened 4 years ago Updated 4 years ago
[e10s] Accessible Caret is appeared even if PC have no touch screen on GTK3
58 bytes, text/x-review-board-request
Actually, accessible caret is appeared when PC has touch screen. Although my PC doesn't have touch screen, this caret is appeared when selecting text. But this issue is only on Nightly e10s. When I turn off e10s, this doesn't occur. Although I add a comment by bug 1137555 comment #9 a past year, IsTouchDeviceSupportPresent runs on content process. I think that this can fix by this method that runs on chrome process.
Also, we disable xinput2 as default. So if MOZ_USE_XINPUT2 isn't set, IsTouchDeviceSupportPresent might be able to return false.
If you only started seeing this recently, it's probably because in bug 1195722 I added a layout.accessiblecaret.enabled_on_touch pref (true by default) which enables the accessible caret if touch support is detected. But on Linux that should only happen if your IsTouchDeviceSupportPresent function is returning true - why it's doing that on a non-touchscreen device I have no idea. I don't think the content process/chrome process thing matters here, but maybe it does.
I am more investigating this issue... More root cause is the following. - Although we turn off xinput2 on main process, it isn't turned off on content process. So gdk_device_manager_list_devices doesn't return same list on content process. So IsTouchDeviceSupportPresent doesn't return same value on content vs chrome. - I file GTK bug (https://bugzilla.gnome.org/show_bug.cgi?id=770716). GTK might detect some mouse devices as touch screen.
/cc :acomminos, he might be interested in comment 3.
Comment on attachment 8798708 [details] Bug 1299707 - Disable XInput2 without MOZ_USE_USE_XINPUT2 on content process. https://reviewboard.mozilla.org/r/84136/#review84972 Looks good, thank you!
Attachment #8798708 - Flags: review?(andrew) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/f82c28837b07 Disable XInput2 without MOZ_USE_USE_XINPUT2 on content process. r=acomminos
Backout by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/861d1ff45502 Backed out changeset f82c28837b07 for crashes @ gdk_disable_multidevice
Assignee: nobody → m_kato
Status: NEW → ASSIGNED
You need to log in before you can comment on or make changes to this bug.