1299760 - testcase for an animated viewBox affecting clip-path.

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[u459114]

According to bug 1289011 comment 26, heycam ask for a test for an animated viewBox="" affecting clip-path.

Comment 1

[u459114]

Attachment: Bug 1299760 - a testcase for animated-viewBox affecting clip-path.

Review commit: https://reviewboard.mozilla.org/r/82288/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/82288/

Comment 2

[Cameron McCormack (:heycam)]

Comment on attachment 8796416 [details]
Bug 1299760 - a testcase for animated-viewBox affecting clip-path.

https://reviewboard.mozilla.org/r/82288/#review80908

r=me with this change.

::: layout/reftests/svg/clip-path-viewBox-animation.svg:7
(Diff revision 1)
> +  <![CDATA[
> +    window.addEventListener("load", function () {
> +      setTimeout(function () {
> +        document.documentElement.removeAttribute("class");
> +      }, 2000);
> +    }, false);
> +  ]]>

Instead of waiting 2s, please use the same technique that tests in layout/reftests/svg/smil/ do, i.e. using setTimeAndSnapshot from smil-util.js.

Comment 3

[u459114]

Comment on attachment 8796416 [details]
Bug 1299760 - a testcase for animated-viewBox affecting clip-path.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/82288/diff/1-2/

Comment 4

[u459114]

Comment on attachment 8796416 [details]
Bug 1299760 - a testcase for animated-viewBox affecting clip-path.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/82288/diff/2-3/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7f9e6e421e24
a testcase for animated-viewBox affecting clip-path. r=heycam

Comment 6

[Phil Ringnalda (:philor)]

Backed out in https://hg.mozilla.org/integration/autoland/rev/56eaf28ca07b for failing on Win8 and Android, https://treeherder.mozilla.org/logviewer.html#?job_id=4285641&repo=autoland and https://treeherder.mozilla.org/logviewer.html#?job_id=4281261&repo=autoland

Comment 7

[u459114]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=64bdbeeed2a1

Comment 8

[u459114]

https://hg.mozilla.org/integration/mozilla-inbound/rev/adf1eb119bd2998a9b293f962405b8a2d5d29618
Bug 1299760 - a testcase for animated-viewBox affecting clip-path. r=heycam

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/adf1eb119bd2