Typo in nsMsgThreadDBView setting view flags

RESOLVED FIXED in Thunderbird 51.0

Status

Thunderbird
Mail Window Front End
--
minor
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: rkent, Assigned: rkent)

Tracking

Trunk
Thunderbird 51.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
While reviewing bug 1266698, I came across the following code in nsMsgThreadedDBView.cpp:

      m_viewFlags |= nsMsgViewFlagsType::kThreadedDisplay;
      m_viewFlags &= nsMsgViewFlagsType::kGroupBySort;

That seems to be an obvious typo. Other occurrences have the expected:

    m_viewFlags |= nsMsgViewFlagsType::kThreadedDisplay;
    m_viewFlags &= ~nsMsgViewFlagsType::kGroupBySort;
(Assignee)

Comment 1

2 years ago
Created attachment 8787312 [details] [diff] [review]
The fix

I don't really understand the possible ramifications of this typo, but the code as written makes no sense.
Assignee: nobody → rkent
Status: NEW → ASSIGNED
Attachment #8787312 - Flags: review?(alta88)

Comment 2

2 years ago
Comment on attachment 8787312 [details] [diff] [review]
The fix

Although it's possible to sort so that all root threads with children will be listed ahead of threads with no children (only if mailnews.thread_pane_column_unthreads is false; default is true), attempting to then Group By will change the sortType to byDate. Likely no ramifications, but kGroupBySort flag should indeed be cleared.
Attachment #8787312 - Flags: review?(alta88) → review+
(Assignee)

Comment 3

2 years ago
http://hg.mozilla.org/comm-central/rev/fe75fb786584
Severity: normal → minor
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 51.0
You need to log in before you can comment on or make changes to this bug.