1299891 - Mark pageAction panels as tab-specific

Status: VERIFIED FIXED

(WebExtensions :: Frontend, defect, P1)

Description

[Kris Maglione [:kmag]]

so that they close when the tab changes.

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1299891: Make pageAction panels tab-specific.

Review commit: https://reviewboard.mozilla.org/r/82442/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/82442/

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8796684 [details]
Bug 1299891: Make pageAction panels tab-specific.

https://reviewboard.mozilla.org/r/82442/#review82518

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a2a991b97a8
Make pageAction panels tab-specific. r=jaws

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/4a2a991b97a8

Comment 6

[Gerry Chang [:gchang]]

Mark 51 as fix-optional. If it's worth uplifting to 51, feel free to nominate it.

Comment 7

[Kris Maglione [:kmag]]

Comment on attachment 8796684 [details]
Bug 1299891: Make pageAction panels tab-specific.

Approval Request Comment
[Feature/regressing bug #]: N/A
[User impact if declined]: Prior to this change, tab-specific panels often stayed open after switching away from the tab that they apply to. This causes some confusion, and has been reported multiple times.
[Describe test coverage new/current, TreeHerder]: The behavior of these panels is thoroughly tested, and this patch adds additional tests for the new behavior.
[Risks and why]: Very low. This is a one-line change which adds a single attribute to a <panel> element. The panels already auto-close in this manner when they lose focus. This change just extends the behavior to a related circumstance.
[String/UUID change made/needed]: None.

Comment 8

[Gerry Chang [:gchang]]

Hi :kmag,
What is the feature or regressing bug of this issue?

Comment 9

[Kris Maglione [:kmag]]

Tab-specific panels were implemented in bug 1171746

Comment 10

[Gerry Chang [:gchang]]

Comment on attachment 8796684 [details]
Bug 1299891: Make pageAction panels tab-specific.

Enhance user behaviors. Take it in 51 aurora.

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/3d23864a4a56

Comment 12

[Vasilica Tamas, QA [:vtamas]]

I was able to reproduce the initial issue on Firefox 49.0.1 under Windows 10 64-bit.

Verified fixed on Firefox 52.0a1 (2016-10-19) and Firefox 51.0a2 (2016-10-19) under Windows 10 64-bit, Ubuntu 16.04 32-bit and Mac OS X 10.12.1. PageAction panel is successfully closed while:
  - opening a new tab (CTRL/CMD+T)
  - switching between tabs (CTRL+TAB)
  - closing a tab (CTRL/CMD+W)