1299914 - Recently Bookmarked list shows old bookmarks that got imported through Sync

Status: RESOLVED DUPLICATE of bug 676563

(Firefox :: Sync, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

STR:
In profile A, create 10 bookmarks
Log in to a Firefox account
Create a new profile B
In profile B, log in to your Firefox account and start syncing

The Recently Bookmarked list doesn't show the last 5 bookmarks that were created. They are probably the last 5 synced. It looks like we are losing some timestamps.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Thanks Jaws - do you believe this is a recent regression? We recently landed stuff that may or may not be related :)

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

I don't know. I just saw this when setting up a new machine over the previous weekend.

Comment 3

[Lina Butler (ex-Mozilla)]

The plot thickens! The new stuff Mark's referring to uses the current time, so that certainly seems wrong... http://searchfox.org/mozilla-central/rev/3582398bc9db5a83e25c2a8299cc780a52ad7ca8/toolkit/components/places/PlacesSyncUtils.jsm#857-859

...But the old stuff (https://hg.mozilla.org/mozilla-central/file/7bab284d7910/services/sync/modules/engines/bookmarks.js) doesn't call `setItemDateAdded` or `setItemLastModified`, either, so I'm not sure if this is a regression in 51 or something we've always done.

Comment 4

[Lina Butler (ex-Mozilla)]

The fix is a bit involved, so prioritizing as P3 for now.

Comment 5

[Lina Butler (ex-Mozilla)]

This is important for Activity Stream, too, so I expect we'll come up with a plan in the coming quarter. Closing this one as a dupe because we're using bug 676563 for the product board.