Closed
Bug 1299949
Opened 8 years ago
Closed 7 years ago
Fix ActivityStream classname and package location
Categories
(Firefox for Android Graveyard :: Awesomescreen, defect)
Firefox for Android Graveyard
Awesomescreen
Tracking
(firefox51 affected, firefox55 fixed)
RESOLVED
FIXED
Firefox 55
People
(Reporter: ahunt, Assigned: ahunt)
Details
Attachments
(2 files)
We currently have two identically named classes: org.mozilla.gecko.activitystream.ActivityStream org.mozilla.gecko.home.activitystream.ActivityStream The second one should probably be renamed to something like "ActivityStreamLayout" or "ActivityStreamView". It would probably also be useful to move everything into one package, e.g. we could put everything into org.mozilla.gecko.activitystream and remove org.mozilla.gecko.home.activitystream?
Assignee | ||
Comment 1•8 years ago
|
||
To avoid unnecessary conflicts I'd prefer to wait until the Favicon code has landed (since it touches the TopSites classes) before doing any package changes.
Assignee: nobody → ahunt
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8862307 [details] Bug 1299949 - Pre: rename ActivityStream UI to ActivityStreamPanel https://reviewboard.mozilla.org/r/134232/#review137274
Attachment #8862307 -
Flags: review?(s.kaspari) → review+
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8862308 [details] Bug 1299949 - Move omg.home.activitystream into omg.activitystream.homepanel https://reviewboard.mozilla.org/r/134234/#review138416
Attachment #8862308 -
Flags: review?(s.kaspari) → review+
Pushed by ahunt@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2808b9d8b263 Pre: rename ActivityStream UI to ActivityStreamPanel r=sebastian https://hg.mozilla.org/integration/autoland/rev/bc35254d72e1 Move omg.home.activitystream into omg.activitystream.homepanel r=sebastian
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2808b9d8b263 https://hg.mozilla.org/mozilla-central/rev/bc35254d72e1
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•