1299976 - Random v-c-t ansible cleanup

Status: RESOLVED FIXED

(Developer Services :: General, task)

Description

[Gregory Szorc [:gps]]

Looking through the Ansible code in v-c-t, there are a few things that are out of date and could be cleaned up. Patches forthcoming.

Comment 1

[Gregory Szorc [:gps]]

Attachment: ansible: remove openssh-lpk role (bug 1299976);

With hg-reviewboard now using CentOS 7, there is no longer a need
to run OpenSSH with the LPK patch set. This role is now unusued,
so nuke it. Good riddance.

Review commit: https://reviewboard.mozilla.org/r/76206/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/76206/

Comment 2

[Gregory Szorc [:gps]]

Attachment: ansible/hg-web: consolidate code for httpd service (bug 1299976);

There were 2 instances doing essentially the same thing. Consolidate
them.

Review commit: https://reviewboard.mozilla.org/r/76210/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/76210/

Comment 3

[Gregory Szorc [:gps]]

Attachment: ansible/hg-ssh: consolidate service management (bug 1299976);

We can use state=restarted to restart a service. This means we only
need 1 service block, not 2.

Review commit: https://reviewboard.mozilla.org/r/76212/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/76212/

Comment 4

[Kendall Libby [:fubar] (he/him)]

Comment on attachment 8787457 [details]
ansible: remove openssh-lpk role (bug 1299976);

https://reviewboard.mozilla.org/r/76206/#review74414

Burn it with fire!

Comment 5

[Kendall Libby [:fubar] (he/him)]

Comment on attachment 8787458 [details]
ansible/hg-web: consolidate code for httpd service (bug 1299976);

https://reviewboard.mozilla.org/r/76210/#review74416

shipit

Comment 6

[Kendall Libby [:fubar] (he/him)]

Comment on attachment 8787459 [details]
ansible/hg-ssh: consolidate service management (bug 1299976);

https://reviewboard.mozilla.org/r/76212/#review74420

Nice!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/09dd07597c2c
ansible: remove openssh-lpk role ; r=fubar
https://hg.mozilla.org/hgcustom/version-control-tools/rev/56ecbfec11b9
ansible/hg-web: consolidate code for httpd service ; r=fubar
https://hg.mozilla.org/hgcustom/version-control-tools/rev/88168b7cab50
ansible/hg-ssh: consolidate service management ; r=fubar