1299977 - Miscellaneous small AS prototype appearance improvements

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Andrzej Hunt :ahunt]

- Fix background colour
- Remove redundant topsites title (since we're back in the homepager)
- Add divider between topsites and highlights
- Increase size of highlight title
- Fix paddings around various cards

Maybe also:
- Update highlights to new appearance?

Comment 1

[Andrzej Hunt :ahunt]

Attachment: Bug 1299977 - Improve Activity Stream topsites appearance

This patch:
- moves padding, so that the topsites pagers uses the full screen width (otherwise
  topsites cards start disappearing where the padding starts when scrolling,
  which looks odd)
- Adjusts background colour for AS.
- Removes redundant TopSites title
- Adds a divider to the bottom of topsites / above Highlights.

Review commit: https://reviewboard.mozilla.org/r/76228/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/76228/

Comment 2

[Andrzej Hunt :ahunt]

Attachment: Bug 1299977 - Update Activity Stream background colour

Review commit: https://reviewboard.mozilla.org/r/76230/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/76230/

Comment 3

[Andrzej Hunt :ahunt]

Attachment: Bug 1299977 - WIP: Adjust appearance of highlights

Review commit: https://reviewboard.mozilla.org/r/76232/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/76232/

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8787478 [details]
Bug 1299977 - Improve Activity Stream topsites appearance

https://reviewboard.mozilla.org/r/76228/#review74372

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8787479 [details]
Bug 1299977 - Update Activity Stream background colour

https://reviewboard.mozilla.org/r/76230/#review74374

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8787480 [details]
Bug 1299977 - WIP: Adjust appearance of highlights

https://reviewboard.mozilla.org/r/76232/#review74376

This last WIP patch could conflict with the changes in bug 1293710.

Comment 7

[Andrzej Hunt :ahunt]

(In reply to Sebastian Kaspari (:sebastian) from comment #6)
> Comment on attachment 8787480 [details]
> Bug 1299977 - WIP: Adjust appearance of highlights
> 
> https://reviewboard.mozilla.org/r/76232/#review74376
> 
> This last WIP patch could conflict with the changes in bug 1293710.

Ah, I missed that part. I'll probably abandon this commit for now, but we can always reuse parts of it in future!

Comment 8

[Andrzej Hunt :ahunt]

https://hg.mozilla.org/integration/fx-team/rev/a079fff17735b34514f120e891ca49ad1501d7b0
Bug 1299977 - Improve Activity Stream topsites appearance r=sebastian

https://hg.mozilla.org/integration/fx-team/rev/46e86751a3429cd64ae06d3029008a20cff67d64
Bug 1299977 - Update Activity Stream background colour r=sebastian

Comment 9

[Andrzej Hunt :ahunt]

https://hg.mozilla.org/integration/fx-team/rev/18ab41c28e2e073d7a8d1854b565236b44ce9ba7
Bug 1299977 - Add TopSites title to UnusedResourcesUtil r=me

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a079fff17735
https://hg.mozilla.org/mozilla-central/rev/46e86751a342
https://hg.mozilla.org/mozilla-central/rev/18ab41c28e2e