Geolocation::GetCurrentPosition leaks when there are too many pending requests

RESOLVED FIXED in Firefox 51

Status

()

Core
DOM
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: bz, Assigned: bz)

Tracking

Trunk
mozilla51
Points:
---

Firefox Tracking Flags

(firefox51 fixed)

Details

Attachments

(1 attachment)

The "options" arg is just allocated by callers, and doesn't get freed if we take the early return before creating the nsGeolocationRequest.
Created attachment 8787495 [details] [diff] [review]
Make sure that our PositionOptions structs are always owned by someone in geolocation code
Attachment #8787495 - Flags: review?(kchen)
Comment on attachment 8787495 [details] [diff] [review]
Make sure that our PositionOptions structs are always owned by someone in geolocation code

Review of attachment 8787495 [details] [diff] [review]:
-----------------------------------------------------------------

I think now UniquePtr is preferred over nsAutoPtr. Feel free to leave it as is, I can change it in followups.
Attachment #8787495 - Flags: review?(kchen) → review+

Comment 3

2 years ago
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/275ec9b898aa
Make sure that our PositionOptions structs are always owned by someone in geolocation code.  r=kanru

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/275ec9b898aa
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox51: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.