Closed Bug 1300006 Opened 8 years ago Closed 7 years ago

stylo: Use newtype instead of typedef for ServoBindings safety wrappers

Categories

(Core :: CSS Parsing and Computation, defect, P4)

defect

Tracking

()

RESOLVED WONTFIX

People

(Reporter: manishearth, Assigned: manishearth)

References

(Depends on 1 open bug)

Details

In bug 1299392, we added more DECL_FOO_TYPE_FOR typedefs to ServoBindings.h. These just typedef to a raw pointer, so using one in the .h file will not necessarily guarantee that the right one is used on the C++ side. On the C++ side this is mostly a visual hint, but a valuable one at that.

We should use a newtype with conversion constructors/operators instead.
Summary: Use newtype instead of typedef for ServoBindings safety wrappers → stylo: Use newtype instead of typedef for ServoBindings safety wrappers
Priority: -- → P4
I think this is fine as is, actually.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.