1300066 - Simplify icon handling for reader view

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Reader View, defect, P5)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

From bug 1290014..

Our code to show (fav)icons in reader view is a bit over-complex:

  Reader mode extracts the article content. We insert the content into a new document (about:reader).
  Some events are exchanged to lookup the icon URL for the actual website. This
  URL is then added to the markup which will then trigger our icon loading code in
  the Tab class.

1) The Tab class could just lookup and load the icon itself. All it needs to do is to strip the about:reader
URL and perform a normal icon load from cache. No handshaking needed.

2) A more global solution (looking at desktop and iOS) would be to copy the <link> markup from the original page to the about:reader page and then rely on our normal icon loading code. This would work even if we do not have anything in the cache for some kind of reason.

Comment 1

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 2

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.