1300107 - click on URL in add-on details fails

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: General, defect)

Description

[Marco A.G.Pinto [:marcoagpinto]]

Attachment: error message

When I click on any links in the add-ons tab, it attempts to open a tab with the page but I get an invalid link text in it (see screenshot).

Comment 1

[Wayne Mery (:wsmwk)]

WFM with prior beta 47.0b2.  perhaps jorg knows what's going on

Error: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIWebNavigation.loadURIWithOptions]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://global/content/bindings/browser.xml :: loadURIWithFlags/< :: line 152"  data: no]

Comment 2

[Alice0775 White]

Regression window:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=2afd8fa9bb5df5577e5566468bb423b76c63cc77&tochange=403912ca555eb65f814b18ecf38ad8e8e98569f5
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=29b988292b20&tochange=1783ef06e72b

Suspect: Bug 1268943

Comment 3

[Jorg K (CEST = GMT+2)]

Thanks for reporting this. I've noticed this a while ago but was possibly busy with other things at the time. ;-(
Fails in Daily, too.

Perhaps Aceman can take a look.

Comment 4

[Jorg K (CEST = GMT+2)]

Further to comment #1: The console shows:
[Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIWebNavigation.loadURIWithOptions]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://global/content/bindings/browser.xml :: loadURIWithFlags/< :: line 152"  data: no]

loadURIWithFlags/<        chrome://global/content/bindings/browser.xml:152:15
_wrapURIChangeCall        chrome://global/content/bindings/browser.xml:49:17
loadURIWithFlags          chrome://global/content/bindings/browser.xml:151:13
loadURI/<                 chrome://global/content/bindings/browser.xml:120:15
_wrapURIChangeCall        chrome://global/content/bindings/browser.xml:49:17
loadURI                   chrome://global/content/bindings/browser.xml:119:13
contentTab_onTabOpened    chrome://messenger/content/specialTabs.js:639:7
openTab                   chrome://messenger/content/tabmail.xml:565:11
MailGlue__handleLink      resource://gre/components/mailGlue.js:131:11
MailGlue_observe          resource://gre/components/mailGlue.js:65:7
open                      chrome://global/content/bindings/text.xml:361:11
onxblclick                chrome://global/content/bindings/text.xml:380:1

Not sure were the error is generated. Here?
https://dxr.mozilla.org/comm-central/rev/abb69c6bc4d47529ec40758e705f039fc9b68d2b/mozilla/toolkit/content/widgets/browser.xml#152

Or nsIWebNavigation.loadURIWithOptions isn't happy?

Oh, those lovely cryptic JS messages.

The bug which maybe cause this made this change:
https://hg.mozilla.org/mozilla-central/rev/a356bf678567#l1.12

Comment 5

[:aceman]

At chrome://global/content/bindings/browser.xml:152, the aURI contains all this object: '{"shiftKey":false,"ctrlKey":false,"metaKey":false,"altKey":false,"button":0,"href":"http://console2.mozdev.org/index.html"}', not just the URL.

Then this error follows:

Security Error: Content at about:neterror?e=malformedURI&u=%7B%22shiftKey%22%3Afalse%2C%22ctrlKey%22%3Afalse%2C%22metaKey%22%3Afalse%2C%22altKey%22%3Afalse%2C%22button%22%3A0%2C%22href%22%3A%22http%3A//console2.mozdev.org/index.html%22%7D&c=&f=regular&d=The%20URL%20is%20not%20valid%20and%20cannot%20be%20loaded. may not load or link to chrome://global/skin/icons/warning-16.png.

So it seems it is using that whole object as the URL to load.

It is possible we need to port the change in browser/components/nsBrowserGlue.js from the patch Jorg linked.

Comment 6

[:aceman]

Attachment: patch

This fixes it for the addon links. But I don't know what other links this is called on. I tried e.g. the mozilla.org link in About dialog and it worked too.

Links in messages (and the others in About dialog) do not work for me regardless of the patch (they show the dialog to choose app).

Comment 7

[Jorg K (CEST = GMT+2)]

Comment on attachment 8791437 [details] [diff] [review]
patch

Tested this:
Links in add-on details work again.
All links in "About Daily" work, some open in FF.
Links in messages also work, they open in FF.

Comment 8

[Magnus Melin [:mkmelin]]

Comment on attachment 8791437 [details] [diff] [review]
patch

Review of attachment 8791437 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin

Comment 9

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/3a753aeb7fad
(ready for today's Daily, thanks!!)

Comment 10

[Jorg K (CEST = GMT+2)]

Comment on attachment 8791437 [details] [diff] [review]
patch

This needs to be uplifted to make it into the upcoming TB 50 beta.

Comment 11

[Jorg K (CEST = GMT+2)]

Aurora (TB 50):
https://hg.mozilla.org/releases/comm-aurora/rev/a8ddbce782b0