1300124 - MurmurHash3.cpp includes <stdlib.h> inside an anonymous namespace

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Nathan Froyd [:froydnj]]

This might work--by accident--with MSVC, but it doesn't work with clang-cl's <stdlib.h>, and I'm not even sure it's supposed to work according to the standard.  (For instance, if you declare something in the std namespace, you're not actually declaring it in ::std, but someplace else, and that can cause problems later on.)

Moving it out of the anonymous namespace, while causing slightly more code to be included, isn't going to hurt in the long run.

Of course, "why another hashing implementation, when we already have one in MFBT?" is a reasonable question, but we can leave that for another day...

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: Bug 1300124 - make MurmurHash3.cpp compile with clang-cl;

Including headers inside anonymous namespaces, especially standard headers,
is super-unusual; let's just move the header to the toplevel instead.

Review commit: https://reviewboard.mozilla.org/r/77032/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/77032/

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8788600 [details]
Bug 1300124 - make MurmurHash3.cpp compile with clang-cl;

https://reviewboard.mozilla.org/r/77032/#review75220

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a9e15f606420
make MurmurHash3.cpp compile with clang-cl; r=bkelly

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a9e15f606420