1300163 - Support running Android mochitests on interactive loaners

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[Andrew Halberstadt [:ahal]]

Currently, we can't run any Android tests on interactive loaners. Let's fix that.

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1300163 - Move the Android 'stop-emulator' step to a PostScriptAction of 'run-tests',

Currently 'stop-emulator' is its own action in mozharness. This means that anytime the mozharness
script finishes emulators will get shutdown. Usually, this is what we want to do. But if the user passes
in --no-run-tests, then presumably they are intending to run tests at a later time for some reason.
But when they do this, the emulator will be terminated, and then running tests later no longer works.

The main place where this becomes a problem is on interactive loaners in taskcluster. This patch fixes
the problem by instead running 'stop-emulator' only after the 'run-tests' step finishes. So if
--no-run-tests is passed in, the emulator will be left open.

Review commit: https://reviewboard.mozilla.org/r/76444/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/76444/

Comment 2

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1300163 - Add a --adbpath argument to mochitest Android to allow explicitly setting the adb binary,

In mozdevice, it's possible to pass in the path to the adb binary (rather than requiring it to be on the path). The
mochitest android options don't provide any means to set this however (even though the b2g options do). This patch
adds that option in.

This will be used by the mach environment on interactive loaners.

Review commit: https://reviewboard.mozilla.org/r/76446/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/76446/

Comment 3

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1300163 - Fix hidden tracebacks in mochitest runtests.py,

I had a mistake in my code that resulted in an exception being thrown when starting the
mochitest servers. However, the log just showed a timeout. It was very confusing.

After some digging, I found that there's a large try:finally block (with no except) in
runtests.py. The exception wasn't being displayed because of the finally block. This
try:finally block had an inner try:except:finally that wrapped part of the code. This
patch simply removes that inner block and dedents the 'except' clause to attach to the
original try:finally.

Review commit: https://reviewboard.mozilla.org/r/76448/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/76448/

Comment 4

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1300163 - Lazy load certain mach context attributes using the 'key' mechanism,

You can set attributes on a mach context by using the 'key' argument to the context_handler. Basically,
whatever gets returned by the handler when <key> is passed in, will get set (i.e cached) on the context
object for fast retrieval next time. This is a way to lazy load these attributes.

Previously I was setting functions like 'find_firefox()' on the context object, and then having the
mach_commands call that directly. But this way is much cleaner.

Now, the loaded 'mozharness_config' can be stored as an attribute on the context. Also 'find_firefox()'
is now an attribute called 'firefox_bin'.

Review commit: https://reviewboard.mozilla.org/r/76450/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/76450/

Comment 5

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1300163 - Reuse the 'e10s' value from the mozharness config on interactive loaners,

I noticed that if you request a loaner for a non-e10s job then run mach, it will be run with e10s
enabled. The mach command should accurately reflect the type of job that got requested. This patch
grabs the 'e10s' argument from the mozharness localconfig.json and uses that.

Review commit: https://reviewboard.mozilla.org/r/76452/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/76452/

Comment 6

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1300163 - Add support for Android mochitests to interactive loaners,

This will allow developers to request a loaner for an Android mochitest job and then use
|mach mochitest| to run tests.

Review commit: https://reviewboard.mozilla.org/r/76454/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/76454/

Comment 7

[Armen [:armenzg]]

Comment on attachment 8787759 [details]
Bug 1300163 - Add support for Android mochitests to interactive loaners,

https://reviewboard.mozilla.org/r/76454/#review74528

Comment 8

[Armen [:armenzg]]

Comment on attachment 8787758 [details]
Bug 1300163 - Reuse the 'e10s' value from the mozharness config on interactive loaners,

https://reviewboard.mozilla.org/r/76452/#review74526

Comment 9

[Armen [:armenzg]]

Comment on attachment 8787757 [details]
Bug 1300163 - Lazy load certain mach context attributes using the 'key' mechanism,

https://reviewboard.mozilla.org/r/76450/#review74524

Comment 10

[Armen [:armenzg]]

Comment on attachment 8787756 [details]
Bug 1300163 - Fix hidden tracebacks in mochitest runtests.py,

https://reviewboard.mozilla.org/r/76448/#review74520

Comment 11

[Geoff Brown [:gbrown]]

Comment on attachment 8787754 [details]
Bug 1300163 - Move the Android 'stop-emulator' step to a PostScriptAction of 'run-tests',

https://reviewboard.mozilla.org/r/76444/#review74536

Comment 12

[Geoff Brown [:gbrown]]

Comment on attachment 8787755 [details]
Bug 1300163 - Add a --adbpath argument to mochitest Android to allow explicitly setting the adb binary,

https://reviewboard.mozilla.org/r/76446/#review74538

Comment 13

[Andrew Halberstadt [:ahal]]

Comment on attachment 8787754 [details]
Bug 1300163 - Move the Android 'stop-emulator' step to a PostScriptAction of 'run-tests',

https://reviewboard.mozilla.org/r/76442/#review75108

Here's a try run:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=bb106ccdcbdbd6922268f649b28d3b5e110e704e

Comment 14

[Andrew Halberstadt [:ahal]]

Comment on attachment 8787754 [details]
Bug 1300163 - Move the Android 'stop-emulator' step to a PostScriptAction of 'run-tests',

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/76444/diff/1-2/

Comment 15

[Andrew Halberstadt [:ahal]]

Comment on attachment 8787755 [details]
Bug 1300163 - Add a --adbpath argument to mochitest Android to allow explicitly setting the adb binary,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/76446/diff/1-2/

Comment 16

[Andrew Halberstadt [:ahal]]

Comment on attachment 8787756 [details]
Bug 1300163 - Fix hidden tracebacks in mochitest runtests.py,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/76448/diff/1-2/

Comment 17

[Andrew Halberstadt [:ahal]]

Comment on attachment 8787757 [details]
Bug 1300163 - Lazy load certain mach context attributes using the 'key' mechanism,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/76450/diff/1-2/

Comment 18

[Andrew Halberstadt [:ahal]]

Comment on attachment 8787758 [details]
Bug 1300163 - Reuse the 'e10s' value from the mozharness config on interactive loaners,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/76452/diff/1-2/

Comment 19

[Andrew Halberstadt [:ahal]]

Comment on attachment 8787759 [details]
Bug 1300163 - Add support for Android mochitests to interactive loaners,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/76454/diff/1-2/

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f72acbecdf93
Move the Android 'stop-emulator' step to a PostScriptAction of 'run-tests', r=gbrown
https://hg.mozilla.org/integration/autoland/rev/1b40346919cc
Add a --adbpath argument to mochitest Android to allow explicitly setting the adb binary, r=gbrown
https://hg.mozilla.org/integration/autoland/rev/574003ffca89
Fix hidden tracebacks in mochitest runtests.py, r=armenzg
https://hg.mozilla.org/integration/autoland/rev/7d4b9b9df5d2
Lazy load certain mach context attributes using the 'key' mechanism, r=armenzg
https://hg.mozilla.org/integration/autoland/rev/e786511a99e1
Reuse the 'e10s' value from the mozharness config on interactive loaners, r=armenzg
https://hg.mozilla.org/integration/autoland/rev/dd6f0732c260
Add support for Android mochitests to interactive loaners, r=armenzg

Comment 21

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f72acbecdf93
https://hg.mozilla.org/mozilla-central/rev/1b40346919cc
https://hg.mozilla.org/mozilla-central/rev/574003ffca89
https://hg.mozilla.org/mozilla-central/rev/7d4b9b9df5d2
https://hg.mozilla.org/mozilla-central/rev/e786511a99e1
https://hg.mozilla.org/mozilla-central/rev/dd6f0732c260