1300329 - Mistakes in property syntaxes

Status: RESOLVED FIXED

(Developer Documentation Graveyard :: CSS, defect, P5)

Description

[rdvornov]

:: Developer Documentation Request

      Request Type: Correction
     Gecko Version: unspecified
 Technical Contact: 

:: Details

I found some mistakes in property syntaxes. Unfortunately I can to edit the page.

-webkit-tap-highlight-color: (uncompleted syntax)
  [ERROR] Error: Unexpected input:
    <color>[, <
  --------------^

font: (bad quotes)
  [ERROR] Error: Unexpected input:
    [ [ <‘font-style’> || <font-variant-css21> || <‘font-weight’> || <‘font-stretch’> ]? <‘font-size’> [ / <‘line-height’> ]? <‘font-family’> ] | caption | icon | menu | message-box | small-caption | status-bar
  ------------------^

font-variant: (multiplier should stick to term)
  [ERROR] Error: Unexpected input:
    normal | none | [ <common-lig-values> || <discretionary-lig-values> || <historical-lig-values> || <contextual-alt-values> || stylistic(<feature-value-name>) || historical-forms || styleset(<feature-value-name> #) || character-variant(<feature-value-name> #) || swash(<feature-value-name>) || ornaments(<feature-value-name>) || annotation(<feature-value-name>) || [ small-caps | all-small-caps | petite-caps | all-petite-caps | unicase | titling-caps ] || <numeric-figure-values> || <numeric-spacing-values> || <numeric-fraction-values> || ordinal || slashed-zero || <east-asian-variant-values> || <east-asian-width-values> || ruby ]
  --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------^

font-variant-alternates: (multiplier should stick to term)
  [ERROR] Error: Unexpected input:
    normal | [ stylistic(<feature-value-name>) || historical-forms || styleset(<feature-value-name> #) || character-variant(<feature-value-name> #) || swash(<feature-value-name>) || ornaments(<feature-value-name>) || annotation(<feature-value-name>) ]
  --------------------------------------------------------------------------------------------------^

text-emphasis-style: (missed semicolon)
  [ERROR] Error: Unexpected input:
    none | [[filled | open ] || [dot | circle | double-circle | triangle | sesame ]] | <string&gt
  --------------------------------------------------------------------------------------------^

Comment 1

[Jean-Yves Perrier [:teoli]]

cc/ Sebastian, as he will better at evaluating these errors than me ;-)

Comment 2

[Sebastian Zartner [:sebo]]

Thanks for letting me know! I'll have a look at it.

Sebastian

Comment 3

[Sebastian Zartner [:sebo]]

Fixed. Thank you, rdvornov, for pointing at those issues!
It looks like you used some kind of tool to find those errors. If so, could you tell me its name?

Sebastian

Comment 4

[rdvornov]

Thank you!
Yes, you're right it's a tool output. Recently I started working on syntax match implementation to detailed CSS parser I worked before. So I saw syntax parse error and filled this issue. After that I link syntaxes together and found some syntaxes are missed or wrong (probably I fill issue about that latter). To help myself fix those syntaxes I even made a simple web interface https://csstree.github.io/docs/syntax.html
Next I want to know that syntaxes works well. I implemented match function and made simple interface to validate CSS values https://csstree.github.io/docs/validator.html. I and other developers who tried it found some strange things in validation result, and some syntaxes was fixed.
Here is parser itself https://github.com/csstree/csstree (it was moved aside from CSSO https://github.com/css/csso).
And its patch for your Template:CSSData – https://github.com/csstree/csstree/blob/master/data/patch.json

Comment 5

[Sebastian Zartner [:sebo]]

(In reply to rdvornov from comment #4)
> Thank you!
> Yes, you're right it's a tool output. Recently I started working on syntax
> match implementation to detailed CSS parser I worked before.

That's really cool!

> After that I link syntaxes together and
> found some syntaxes are missed or wrong (probably I fill issue about that
> latter).

Yes, please file them!

> To help myself fix those syntaxes I even made a simple web
> interface https://csstree.github.io/docs/syntax.html
> Next I want to know that syntaxes works well. I implemented match function
> and made simple interface to validate CSS values
> https://csstree.github.io/docs/validator.html. I and other developers who
> tried it found some strange things in validation result, and some syntaxes
> was fixed.
> Here is parser itself https://github.com/csstree/csstree (it was moved aside
> from CSSO https://github.com/css/csso).

Very cool tools! So it looks like the CSSData macro helped you to achieve this goal. :-)

> And its patch for your Template:CSSData –
> https://github.com/csstree/csstree/blob/master/data/patch.json

Could you turn this into a normal patched CSSData.json file or a proper .patch file, so it can be applied easily? That would be great!

Sebastian