1300440 - layers.acceleration.force-enabled crashes with blacklisted devices in debug builds

Status: RESOLVED FIXED

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

The gfxPlatform code looks like this:

  if (!IsGfxInfoStatusOkay(nsIGfxInfo::FEATURE_OPENGL_LAYERS, &message, failureId)) {
    openGLFeature.Disable(FeatureStatus::Blacklisted, message.get(), failureId);
  }
...
  if (gfxPrefs::LayersAccelerationForceEnabledDoNotUseDirectly()) {
    openGLFeature.UserForceEnable("Force-enabled by pref");
  }

On debug builds, if both "if" conditions are true

[e-mail]

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Gah! Sorry about the premature submission.

... if both "if" conditions are true, then in debug builds we get an assertion in gfxFeature because it's been initialized twice. In opt builds there's no assertion so we go ahead and use accelerated layers with the blacklisted device.

I think debug builds should behave like opt builds and layers.acceleration.force-enabled should work even with blacklisted devices.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Created attachment 8788008 [details] [diff] [review]
patch

Make layers.acceleration.force-enabled override blacklisted devices in debug builds.

Opt builds already have this behavior.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Note that this bug breaks layers.acceleration.force-enabled under rr: https://github.com/mozilla/rr/issues/1785.

Comment 4

[Andrew Comminos [:acomminos]]

Comment on attachment 8788008 [details] [diff] [review]
patch

Review of attachment 8788008 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks for the patch!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3895ee3a6dc1
Make layers.acceleration.force-enabled override blacklisted devices in debug builds. r=acominos

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/3895ee3a6dc1