1300508 - [WebGL2] Fix conformance fails for Windows 10

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Comment 1

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1300508 - Fix conformance fails for Windows 10;

Review commit: https://reviewboard.mozilla.org/r/76760/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/76760/

Comment 2

[Daosheng Mu[:daoshengmu]]

Please refer to Bug 1295061. Comparing with Win 8 machines, Win 10 ones have the same hardware and driver environment. It looks make sense to adopt the same fail-if cases. Try result looks good, https://treeherder.mozilla.org/#/jobs?repo=try&revision=06640a136e85

Comment 3

[Ethan Lin[:ethlin]]

Comment on attachment 8788189 [details]
Bug 1300508 - Fix conformance fails for Windows 10;

https://reviewboard.mozilla.org/r/76760/#review74932

::: dom/canvas/test/webgl-mochitest/mochitest.ini:87
(Diff revision 1)
>  # We haven't cleaned up the Try results yet, but let's get this on the books first.
>  [test_webgl_conformance.html]
>  skip-if = toolkit == 'android' #bug 865443- seperate suite - the non_conf* tests pass except for one on armv6 tests
>  [test_webgl_compressed_texture_es3.html]
>  [test_webgl_disjoint_timer_query.html]
> -fail-if = (os == 'win' && (os_version == '6.1' || os_version == '6.2'))
> +fail-if = (os == 'win' && (os_version != '5.1'))

Please mark the failing versions but not what versions work.

Comment 4

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8788189 [details]
Bug 1300508 - Fix conformance fails for Windows 10;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/76760/diff/1-2/

Comment 5

[Ethan Lin[:ethlin]]

Comment on attachment 8788189 [details]
Bug 1300508 - Fix conformance fails for Windows 10;

https://reviewboard.mozilla.org/r/76760/#review75302

Looks good to me.

Comment 6

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8788189 [details]
Bug 1300508 - Fix conformance fails for Windows 10;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/76760/diff/2-3/

Comment 7

[Daosheng Mu[:daoshengmu]]

Thanks for Bug 1297965. Right now, we just need to mark test_webgl_disjoint_timer_query.html test.

Comment 8

[Daosheng Mu[:daoshengmu]]

Comment on attachment 8788189 [details]
Bug 1300508 - Fix conformance fails for Windows 10;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/76760/diff/3-4/

Comment 9

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8788189 [details]
Bug 1300508 - Fix conformance fails for Windows 10;

https://reviewboard.mozilla.org/r/76760/#review77138

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f6aa1cccec36
Fix conformance fails for Windows 10; r=ethlin,jgilbert

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f6aa1cccec36