[WebGL2] Fix conformance fails for Windows 10

RESOLVED FIXED in Firefox 51

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: daoshengmu, Assigned: daoshengmu)

Tracking

unspecified
mozilla51
Points:
---

Firefox Tracking Flags

(firefox51 fixed)

Details

Attachments

(1 attachment)

No description provided.
Assignee: nobody → dmu
Summary: [WebGL2] Fix conformance fail in Windows 10 → [WebGL2] Fix conformance fails for Windows 10
Please refer to Bug 1295061. Comparing with Win 8 machines, Win 10 ones have the same hardware and driver environment. It looks make sense to adopt the same fail-if cases. Try result looks good, https://treeherder.mozilla.org/#/jobs?repo=try&revision=06640a136e85
Comment on attachment 8788189 [details]
Bug 1300508 - Fix conformance fails for Windows 10;

https://reviewboard.mozilla.org/r/76760/#review74932

::: dom/canvas/test/webgl-mochitest/mochitest.ini:87
(Diff revision 1)
>  # We haven't cleaned up the Try results yet, but let's get this on the books first.
>  [test_webgl_conformance.html]
>  skip-if = toolkit == 'android' #bug 865443- seperate suite - the non_conf* tests pass except for one on armv6 tests
>  [test_webgl_compressed_texture_es3.html]
>  [test_webgl_disjoint_timer_query.html]
> -fail-if = (os == 'win' && (os_version == '6.1' || os_version == '6.2'))
> +fail-if = (os == 'win' && (os_version != '5.1'))

Please mark the failing versions but not what versions work.
Attachment #8788189 - Flags: review?(ethlin)
Comment on attachment 8788189 [details]
Bug 1300508 - Fix conformance fails for Windows 10;

https://reviewboard.mozilla.org/r/76760/#review75302

Looks good to me.
Attachment #8788189 - Flags: review?(ethlin) → review+
Thanks for Bug 1297965. Right now, we just need to mark test_webgl_disjoint_timer_query.html test.
Comment on attachment 8788189 [details]
Bug 1300508 - Fix conformance fails for Windows 10;

https://reviewboard.mozilla.org/r/76760/#review77138
Attachment #8788189 - Flags: review?(jgilbert) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f6aa1cccec36
Fix conformance fails for Windows 10; r=ethlin,jgilbert
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f6aa1cccec36
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.