WorkerProxyToMainThreadRunnable::PostDispatchOnMainThread::ReleaseRunnable should implement Cancel() correctly

RESOLVED FIXED in Firefox 51

Status

()

Product:
Core
Component:
DOM: Workers
Status:
RESOLVED FIXED
Reported:
2 years ago
Modified:
2 years ago

People

(Reporter: amarchesini, Assigned: amarchesini)

Tracking

Version:
50 Branch
Target:
mozilla51
Points:
---

Firefox Tracking Flags

(firefox51 fixed)

Details

Attachments

(1 attachment)

worker_cancel.patch
1.09 KB, patch
bkelly
: review+
Details | Diff | Splinter Review
(Assignee)

Description

•
2 years ago 
Created attachment 8788288 [details] [diff] [review]
worker_cancel.patch

Otherwise a crash can occur because of:

MOZ_ASSERT(IsCanceled(), "Subclass Cancel() didn't set IsCanceled()!");
https://dxr.mozilla.org/mozilla-central/source/dom/workers/WorkerRunnable.cpp#261
Attachment #8788288 - Flags: review?(bkelly)
Attachment #8788288 - Flags: review?(bkelly) → review+

Comment 1

•
2 years ago 
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7f00c0316a19
WorkerProxyToMainThreadRunnable::PostDispatchOnMainThread::ReleaseRunnable should implement Cancel() correctly, r=bkelly

Comment 2

•
2 years ago 
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/00bdb9edbe56
part 2 - WorkerProxyToMainThreadRunnable::PostDispatchOnMainThread::ReleaseRunnable should implement Cancel() correctly, r=me

Comment 3

•
2 years ago
bugherder 
https://hg.mozilla.org/mozilla-central/rev/7f00c0316a19
https://hg.mozilla.org/mozilla-central/rev/00bdb9edbe56
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.