Closed
Bug 1300655
Opened 5 years ago
Closed 5 years ago
WorkerProxyToMainThreadRunnable::PostDispatchOnMainThread::ReleaseRunnable should implement Cancel() correctly
Categories
(Core :: DOM: Workers, defect)
Tracking
()
RESOLVED
FIXED
mozilla51
Tracking | Status | |
---|---|---|
firefox51 | --- | fixed |
People
(Reporter: baku, Assigned: baku)
Details
Attachments
(1 file)
1.09 KB,
patch
|
bkelly
:
review+
|
Details | Diff | Splinter Review |
Otherwise a crash can occur because of: MOZ_ASSERT(IsCanceled(), "Subclass Cancel() didn't set IsCanceled()!"); https://dxr.mozilla.org/mozilla-central/source/dom/workers/WorkerRunnable.cpp#261
Attachment #8788288 -
Flags: review?(bkelly)
Updated•5 years ago
|
Attachment #8788288 -
Flags: review?(bkelly) → review+
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/7f00c0316a19 WorkerProxyToMainThreadRunnable::PostDispatchOnMainThread::ReleaseRunnable should implement Cancel() correctly, r=bkelly
Pushed by amarchesini@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/00bdb9edbe56 part 2 - WorkerProxyToMainThreadRunnable::PostDispatchOnMainThread::ReleaseRunnable should implement Cancel() correctly, r=me
Comment 3•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7f00c0316a19 https://hg.mozilla.org/mozilla-central/rev/00bdb9edbe56
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in
before you can comment on or make changes to this bug.
Description
•