Optimize gfxUtils::ConvertBGRAtoRGBA()

RESOLVED FIXED in Firefox 51

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: sotaro, Assigned: sotaro)

Tracking

Trunk
mozilla51
Points:
---

Firefox Tracking Flags

(firefox51 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
gfxUtils::ConvertBGRAtoRGBA() seems not optimum.
(Assignee)

Updated

3 years ago
Assignee: nobody → sotaro.ikeda.g
(Assignee)

Comment 1

3 years ago
Created attachment 8790189 [details] [diff] [review]
patch - Optimize gfxUtils::ConvertBGRAtoRGBA()
(Assignee)

Comment 2

3 years ago
libyuv::ABGRToARGB() is already used similar way in the following.
 https://dxr.mozilla.org/mozilla-central/source/dom/canvas/ImageBitmap.cpp#236
(Assignee)

Comment 3

3 years ago
Before applying attachment 8790189 [details] [diff] [review], thumbnail's color conversion took 0.4ms-1.0ms. By attachment 8790189 [details] [diff] [review], it became 0.3ms.
(Assignee)

Updated

3 years ago
Version: 38 Branch → Trunk
(Assignee)

Updated

3 years ago
Attachment #8790189 - Flags: review?(jmuizelaar)
Attachment #8790189 - Flags: review?(jmuizelaar) → review+

Comment 5

3 years ago
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c75b43f81d5c
Optimize gfxUtils::ConvertBGRAtoRGBA() r=jrmuizel

Comment 6

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c75b43f81d5c
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.