Optimize gfxUtils::ConvertBGRAtoRGBA()

RESOLVED FIXED in Firefox 51

Status

()

Product:
Core
Component:
Graphics
Type:
defect
Status:
RESOLVED FIXED
Opened:
3 years ago
Updated:
3 years ago

People

(Reporter: sotaro, Assigned: sotaro)

Tracking

Version:
Trunk
Target:
mozilla51
Points:
---

Firefox Tracking Flags

(firefox51 fixed)

Details

Attachments

(1 attachment)

patch - Optimize gfxUtils::ConvertBGRAtoRGBA()
2.18 KB, patch
jrmuizel
: review+
Details | Diff | Splinter Review 
gfxUtils::ConvertBGRAtoRGBA() seems not optimum.
Assignee: nobody → sotaro.ikeda.g
libyuv::ABGRToARGB() is already used similar way in the following.
 https://dxr.mozilla.org/mozilla-central/source/dom/canvas/ImageBitmap.cpp#236
Before applying attachment 8790189 [details] [diff] [review], thumbnail's color conversion took 0.4ms-1.0ms. By attachment 8790189 [details] [diff] [review], it became 0.3ms.
Version: 38 Branch → Trunk
Attachment #8790189 - Flags: review?(jmuizelaar)
Attachment #8790189 - Flags: review?(jmuizelaar) → review+
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c75b43f81d5c
Optimize gfxUtils::ConvertBGRAtoRGBA() r=jrmuizel
https://hg.mozilla.org/mozilla-central/rev/c75b43f81d5c
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.