Closed
Bug 1300656
Opened 6 years ago
Closed 6 years ago
Optimize gfxUtils::ConvertBGRAtoRGBA()
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla51
Tracking | Status | |
---|---|---|
firefox51 | --- | fixed |
People
(Reporter: sotaro, Assigned: sotaro)
Details
Attachments
(1 file)
2.18 KB,
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
gfxUtils::ConvertBGRAtoRGBA() seems not optimum.
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → sotaro.ikeda.g
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Comment 2•6 years ago
|
||
libyuv::ABGRToARGB() is already used similar way in the following. https://dxr.mozilla.org/mozilla-central/source/dom/canvas/ImageBitmap.cpp#236
Assignee | ||
Comment 3•6 years ago
|
||
Before applying attachment 8790189 [details] [diff] [review], thumbnail's color conversion took 0.4ms-1.0ms. By attachment 8790189 [details] [diff] [review], it became 0.3ms.
Assignee | ||
Updated•6 years ago
|
Version: 38 Branch → Trunk
Assignee | ||
Comment 4•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0898f35c5425
Assignee | ||
Updated•6 years ago
|
Attachment #8790189 -
Flags: review?(jmuizelaar)
Updated•6 years ago
|
Attachment #8790189 -
Flags: review?(jmuizelaar) → review+
Pushed by sikeda@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c75b43f81d5c Optimize gfxUtils::ConvertBGRAtoRGBA() r=jrmuizel
Comment 6•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c75b43f81d5c
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in
before you can comment on or make changes to this bug.
Description
•