Closed Bug 1300656 Opened 4 years ago Closed 4 years ago

Optimize gfxUtils::ConvertBGRAtoRGBA()

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla51
Tracking Flags:
Tracking Status
firefox51 --- fixed

People

(Reporter: sotaro, Assigned: sotaro)

Details

Attachments

(1 file)

patch - Optimize gfxUtils::ConvertBGRAtoRGBA()
2.18 KB, patch
jrmuizel
: review+
Details | Diff | Splinter Review 
gfxUtils::ConvertBGRAtoRGBA() seems not optimum.
Assignee: nobody → sotaro.ikeda.g
libyuv::ABGRToARGB() is already used similar way in the following.
 https://dxr.mozilla.org/mozilla-central/source/dom/canvas/ImageBitmap.cpp#236
Before applying attachment 8790189 [details] [diff] [review], thumbnail's color conversion took 0.4ms-1.0ms. By attachment 8790189 [details] [diff] [review], it became 0.3ms.
Version: 38 Branch → Trunk
Attachment #8790189 - Flags: review?(jmuizelaar)
Attachment #8790189 - Flags: review?(jmuizelaar) → review+
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c75b43f81d5c
Optimize gfxUtils::ConvertBGRAtoRGBA() r=jrmuizel
https://hg.mozilla.org/mozilla-central/rev/c75b43f81d5c
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in before you can comment on or make changes to this bug.