1300678 - Fix MediaPrefs accesses from the GPU process

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[Matt Woodrow (:mattwoodrow)]

Currently we just skip MediaPrefs calls when we're running in the GPU process (Part 3 of bug 1288618).

We probably want to find a way of making these accessible to the GPU process properly instead of just using default values.

Using gfxVars is probably the easiest way to achieve this.

Comment 1

[Matt Woodrow (:mattwoodrow)]

Attachment: Use gfxVars for media prefs we need to access from the GPU process

Comment 2

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8798249 [details] [diff] [review]
Use gfxVars for media prefs we need to access from the GPU process

Note that these gfxVars lookups won't be live and you'll need to restart the browser for their values to update.

I don't think that should matter too much.

Comment 3

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 8798249 [details] [diff] [review]
Use gfxVars for media prefs we need to access from the GPU process

Review of attachment 8798249 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine assuming jya is okay with liveness.

Comment 4

[Jean-Yves Avenard [:jya]]

Comment on attachment 8798249 [details] [diff] [review]
Use gfxVars for media prefs we need to access from the GPU process

Review of attachment 8798249 [details] [diff] [review]:
-----------------------------------------------------------------

to me it would be better to have the MediaPrefs initialize in the GPU process, it would be a one-liner , same as initialising gfxVars

::: dom/media/platforms/wmf/DXVA2Manager.cpp
@@ +407,5 @@
>      aFailureReason = nsPrintfCString("IDirect3D9Ex::GetAdapterIdentifier failed with error %X", hr);
>      return hr;
>    }
>  
> +  if (adapter.VendorId == 0x1022 && !gfx::gfxVars::PDMWMFSkipBlacklist()) {

can't you initialize the MediaPrefs in the GPU process?

Comment 5

[Matt Woodrow (:mattwoodrow)]

Attachment: move-prefs-to-gfx

So, making MediaPrefs work in the GPU process isn't simple. It uses the Preferences API which isn't available.

gfxPrefs has a manual backend which syncs values over IPDL in order to work in the GPU process.

I don't think it's worth adding the same thing for MediaPrefs (since we're unlikely to need many of them in the GPU process), so how about we just move the relevant prefs across to gfxPrefs?

Comment 6

[Jean-Yves Avenard [:jya]]

Comment on attachment 8798316 [details] [diff] [review]
move-prefs-to-gfx

Review of attachment 8798316 [details] [diff] [review]:
-----------------------------------------------------------------

Disappointing that media related prefs are now defined in two different spots.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/96c3388d513e
Use gfxPrefs for media vars that get accessed from the GPU process. r=jya

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/96c3388d513e