Closed Bug 1300695 Opened 8 years ago Closed 8 years ago

don't build cinnabar with openssl or gettext support

Categories

(MozReview Graveyard :: Testing / Development Environment, defect)

Product:
MozReview Graveyard
Component:
Testing / Development Environment
Version:
Production
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: glob, Assigned: glob)

Details

Attachments

(1 file)

testing: don't build cinnabar with openssl or gettext support (bug 1300695);
58 bytes, text/x-review-board-request
gps
: review+
Details 
building git cinnabar's helper just started throwing errors on my mac:

GIT_VERSION = 2.9.2
    * new build flags
    * new link flags
    * new prefix flags
    GEN common-cmds.h
    CC hex.o
    CC kwset.o
    CC ident.o
In file included from hex.c:1:
In file included from ./cache.h:4:
In file included from ident.c:./git-compat-util.h8::
280In file included from :./cache.h10::4 :
In file included from kwset.c:./git-compat-util.hfatal error37: ::
280In file included from :./cache.h10::4 'openssl/ssl.h':
 filefatal error : not found./git-compat-util.h
'openssl/ssl.h': 280file: 10not:  found
fatal error: 'openssl/ssl.h' file not found#include <openssl/ssl.h>
         ^
#include <openssl/ssl.h>
         ^
#include <openssl/ssl.h>
         ^
1 error generated.
1 error generated.
make[1]: *** [hex.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: *** [ident.o] Error 1
1 error generated.
make[1]: *** [kwset.o] Error 1
make: *** [git-cinnabar-helper] Error 2


osx doesn't ship with openssl any more, so we can't build git-cinnabar.

according to git's INSTALL docs:
- building with NO_OPENSSL drops ssl support for git-imap-send
- building with NO_GETTEXT results in an english only version
note: git-cinnabar built without this fix last week; perhaps a recent system update finally removed the openssl libraries.  *shrugs*
Attachment #8788335 - Flags: review?(gps) → review?(mh+mozilla)
Comment on attachment 8788335 [details]
testing: don't build cinnabar with openssl or gettext support (bug 1300695);

https://reviewboard.mozilla.org/r/76860/#review75222

I have no objections to this at this point in time. However, I feel glandium may be interested, so sending review his way.
Attachment #8788335 - Flags: review+
Comment on attachment 8788335 [details]
testing: don't build cinnabar with openssl or gettext support (bug 1300695);

https://reviewboard.mozilla.org/r/76860/#review75288

::: create-test-environment:225
(Diff revision 1)
>  fi
>  
>  cd venv/git-cinnabar
>  git pull
>  git submodule update --init
> -make -j4 helper
> +NO_OPENSSL=1 NO_GETTEXT=1 make -j4 helper

Not that it would make much practical difference, but I'd put the variables as make command line arguments, not as environment variables.
Attachment #8788335 - Flags: review?(mh+mozilla) → review+
I *think* glob's fix, which I applied locally this morning, is the cause of some test errors I've been seeing in test-push-http.t and another test or two (see below).  I can't confirm, since I can't run the tests without this fix anymore, given that it was an OS X environment change and not any particular commit.

Only two hg error messages show up (sometimes repeatedly).  The rest of the tests run fine, i.e., no unexpected errors.

Error diff of test-push-http.t:

198a199,200
>   remote: REVIEWBOARD: You need to have the reviewboard client extension installed in order to perform code reviews.
>   remote: REVIEWBOARD: See https://hg.mozilla.org/hgcustom/version-control-tools/file/tip/hgext/reviewboard/README.rst
230a233,234
>   remote: REVIEWBOARD: You need to have the reviewboard client extension installed in order to perform code reviews.
>   remote: REVIEWBOARD: See https://hg.mozilla.org/hgcustom/version-control-tools/file/tip/hgext/reviewboard/README.rst
284a289,290
>   remote: REVIEWBOARD: You need to have the reviewboard client extension installed in order to perform code reviews.
>   remote: REVIEWBOARD: See https://hg.mozilla.org/hgcustom/version-control-tools/file/tip/hgext/reviewboard/README.rst
341a348,349
>   remote: REVIEWBOARD: You need to have the reviewboard client extension installed in order to perform code reviews.
>   remote: REVIEWBOARD: See https://hg.mozilla.org/hgcustom/version-control-tools/file/tip/hgext/reviewboard/README.rst

One excerpt from test-push-http.t.err:

  $ hg --config bugzilla.username=user2@example.com --config bugzilla.apikey=${user2key} push ${MERCURIAL_URL}test-repo
  pushing to http://$DOCKER_HOSTNAME:$HGPORT/test-repo
  (adding commit id to 2 changesets)
  saved backup bundle to $TESTTMP/client/.hg/strip-backup/e528ead97c56-8d25fba9-addcommitid.hg (glob)
  searching for changes
  remote: adding changesets
  remote: adding manifests
  remote: adding file changes
  remote: added 2 changesets with 2 changes to 1 files
  remote: recorded push in pushlog
  remote: REVIEWBOARD: You need to have the reviewboard client extension installed in order to perform code reviews.
  remote: REVIEWBOARD: See https://hg.mozilla.org/hgcustom/version-control-tools/file/tip/hgext/reviewboard/README.rst
  submitting 2 changesets for review
(In reply to Mark Côté [:mcote] from comment #5)
> I *think* glob's fix, which I applied locally this morning, is the cause of
> some test errors I've been seeing in test-push-http.t and another test or
> two (see below).  I can't confirm, since I can't run the tests without this
> fix anymore, given that it was an OS X environment change and not any
> particular commit.

i'll check, but it's highly unlikely the errors you're seeing are related to this change.  it only fixes the building of git-cinnabar, which isn't used by the mercurial based tests.
filed bug 1302101
Pushed by bjones@mozilla.com:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/140740c8acca
testing: don't build cinnabar with openssl or gettext support ; r=glandium,gps
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: