1300712 - [iOS 10] 'Go to copied link' option should not be displayed in Today widget in lock mode

Status: RESOLVED WORKSFORME

(Firefox for iOS :: General, defect, P1)

Description

[Simon Basca [:SimonB]]

Attachment: IMG_0028.PNG

Build: 5.2b2
Device: iPad mini 4
iOS: 10b8

Steps to reproduce:
1.Copy a link
2.Lock screen
3.Tap the home button
4.Swipe right and go to Today widget

Actual results:
- 'Go to copied link' option is displayed, but the link is not.

Expected results:
- Both link and 'Go to copied link' option should not be displayed. This is the current functionality on iOS 9.x

Comment 1

[James Hugman [:jhugman] [@jhugman]]

Up until iOS9, there was no reliable way of a today widget telling if it is on the lock screen or not. 

The solution is described in https://github.com/mozilla-mobile/firefox-ios/blob/13186294f11b9bfc3279f94d7497ffcf6691a7a8/Utils/SystemUtils.swift#L31 . This no longer seems to be working.

Comment 2

[Farhan Patel [:farhan]]

It seems like it is still working. But it takes time for it to kick in. You have to wait almost a minute sometimes for it to hide the url. I think this is just Apple not restricting access to the filesystem right away. 
Here is what I did

Steps to reproduce:
1.Copy a link
2.Lock screen
3.Tap the home button
4.Type enough wrong passcodes to get locked out for a min.
5.Swipe right and go to Today widget

This is still the most reliable way of checking if the device is locked or not. So I think it's best to just leave it as is.