Closed Bug 1300719 Opened 8 years ago Closed 7 years ago

Firebug theme - The disable popup auto hide button looks like disable even if it is enabled

Categories

(DevTools :: General, defect, P3)

Product:
DevTools
Component:
General
Version:
48 Branch
Type:
defect

Tracking

(firefox48 wontfix, firefox49 affected, firefox50 affected, firefox51 affected, firefox55 verified)

Status:
RESOLVED FIXED
Milestone:
Firefox 55
Tracking Flags:
Tracking Status
firefox48 --- wontfix
firefox49 --- affected
firefox50 --- affected
firefox51 --- affected
firefox55 --- verified

People

(Reporter: magicp.jp, Assigned: ntim)

References

Details

Attachments

(3 files)

firebug-theme-no-auto-hide-button.png
3.27 KB, image/png
Details
command-noautohide.svg
3.54 KB, image/svg+xml
Details
Bug 1300719 - Update no-autohide firebug theme command button to look less disabled.
59 bytes, text/x-review-board-request
jdescottes
: review+
Details 
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID: 20160905030222

Steps to reproduce:

Please find the no auto hide button in Browser Toolbox with Firebug theme.


Actual results:

The no auto hide button of Firebug theme looks like disable


Expected results:

Fix icon color looks like enable.
Component: Untriaged → Developer Tools
OS: Unspecified → All
Hardware: Unspecified → All
Regression range:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=005449bf12df9fa386f1644823961cebd94ed0e7&tochange=0361b7030d363459416d46e651a8c50c9536788f
Blocks: 1265985
Has Regression Range: --- → yes
Has STR: --- → yes
status-firefox48: --- → wontfix
status-firefox49: --- → affected
status-firefox50: --- → affected
status-firefox51: --- → affected
Summary: Firebug theme - The no auto hide button looks like disable → Firebug theme - The disable popup auto hide button looks like disable
Version: unspecified → 48 Branch
Summary: Firebug theme - The disable popup auto hide button looks like disable → Firebug theme - The disable popup auto hide button looks like disable even if it is enabled
There are two issues.
- Original icon looks like disable
- No differences between enabled and disabled style.
See Also: → 1301042
(In reply to magicp from comment #2)

> - No differences between enabled and disabled style.

I divided this issue then filed to Bug 1301042.
Flags: needinfo?(sebastianzartner)
Attached image command-noautohide.svg — 
In the attached icon I made the border of the tooltip wider and the border of the padlock darker.

Tim, if that's ok for you, can you please create the patch for it?

Sebastian
Flags: needinfo?(sebastianzartner) → needinfo?(ntim.bugs)
Attachment #8851011 - Flags: review?(jryans) → review?(jdescottes)
Flags: needinfo?(ntim.bugs)
Attachment #8851011 - Flags: review?(jdescottes)
Sebastian, thanks for the new icon!
Assignee: nobody → ntim.bugs
Comment on attachment 8851011 [details]
Bug 1300719 - Update no-autohide firebug theme command button to look less disabled.

https://reviewboard.mozilla.org/r/123478/#review126398
Attachment #8851011 - Flags: review?(jdescottes) → review+
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/7d1cfd0b8914
Update no-autohide firebug theme command button to look less disabled. r=jdescottes
https://hg.mozilla.org/mozilla-central/rev/7d1cfd0b8914
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
I have reproduced this bug with Nightly 51.0a1(2016-09-04) on Windows 10, 64 bit!

The Bug's fix is now verified on Latest Nightly 55.0a1

Build ID 	20170329030240
User Agent 	Mozilla/5.0 (Windows NT 10.0; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0

[bugday-20170329]
[bugday-20170329]
status-firefox55: fixed → verified
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: