1300762 - Wrong message displayed after FxA password reset

Status: RESOLVED FIXED

(Cloud Services :: Server: Firefox Accounts, defect)

Description

[Bogdan Maris, Desktop QA]

Attachment: Screenshot showing the issue

[Affected versions]:
- Firefox 49.0 RC
- latest Developer Edition 50.0a2
- latest Nightly 51.0a1

[Affected platforms]:
- Ubuntu 16.04 32-bit
- Mac OS X 10.9.5
- Windows 10 64-bit

[Steps to reproduce]:
1. Visit about:preferences#sync
2. Click 'Sign In'
4. Click 'Forgot Password?'
5. Enter email and click 'Reset password'
6. Click rest password from Email client
7. Enter new Password in both 'New password' and 'Repeat password'
6. Click 'Submit new password'

[Expected result]:
- After step 6, Firefox automatically signs in and a sync is performed.

[Actual result]:
- User is not signed in into account and only 'Firefox Sync will begin momentarily' message is shown, which is confusing.

[Regression range]:
- I am unable to search for a regression due to the fact that this is a server side issue.

[Additional notes]:
- This issue is intermittent, I only reproduced 3/6 tries.

Comment 1

[Ryan Kelly [:rfkelly]]

> only 'Firefox Sync will begin momentarily' message is shown, which is confusing.

This is super weird, as it means the browser *thinks* it's getting a valid login from sync.  Phil, does this sound like it might be related to the other intermittent login issues you've seen lately?

Comment 2

[Phil Booth [:pb]]

(In reply to Ryan Kelly [:rfkelly] from comment #1)
> Phil, does this sound like it might be related to the other intermittent login
> issues you've seen lately?

It's definitely possible. I'll try to reproduce it and debug then come back here to post my findings.

Comment 3

[Phil Booth [:pb]]

(In reply to Ryan Kelly [:rfkelly] from comment #1)
> Phil, does this sound like it might be related to the other intermittent login
> issues you've seen lately?

Yep, I have a strong hunch that this is related to:

https://github.com/mozilla/fxa-content-server/issues/4060

And I have an inkling that both might be caused by something similar to:

https://github.com/mozilla/fxa-auth-server/issues/1383

My clever plan to saturate the content server with extra logging around sign in etc has not worked so far. My next focus is on the session token object in the auth server.

Comment 4

[Ryan Kelly [:rfkelly]]

Shane, given the localStorage theory in [1], do you think this could be due the reset-complete page trying to send the credentials across to the originating tab, but failing because they have different views of localStorage?

[1] https://github.com/mozilla/fxa-content-server/issues/4115#issuecomment-251862414

Comment 5

[Shane Tomlinson [:stomlinson]]

localStorage shouldn't be at play in the communication here - browsers that support BroadcastChannel communicate using BroadcastChannel instead of localStorage.

Comment 6

[Wil Clouser [:clouserw]]

Is this issue still valid?

Comment 7

[Phil Booth [:pb]]

I don't recall seeing it happen in recent memory, closing.